2009-04-25 12:10:21

by Jiri Slaby

[permalink] [raw]
Subject: [PATCH 1/1] ath5k: 5211, don't crypt every protected frame

Hi guys,
do you remember some 5211 HW which didn't work with this?
--

Set null key type even on ar5211, otherwise it en/decrypts every frame with
protected bit set which renders the card unusable on encrypted networks.

Signed-off-by: Jiri Slaby <[email protected]>
Cc: Nick Kossifidis <[email protected]>
Cc: Luis R. Rodriguez <[email protected]>
Cc: Bob Copeland <[email protected]>
---
drivers/net/wireless/ath/ath5k/pcu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath5k/pcu.c b/drivers/net/wireless/ath/ath5k/pcu.c
index 55122f1..5f07e87 100644
--- a/drivers/net/wireless/ath/ath5k/pcu.c
+++ b/drivers/net/wireless/ath/ath5k/pcu.c
@@ -1003,7 +1003,7 @@ int ath5k_hw_reset_key(struct ath5k_hw *ah, u16 entry)
* Note2: Windows driver (ndiswrapper) sets this to
* 0x00000714 instead of 0x00000007
*/
- if (ah->ah_version > AR5K_AR5211) {
+ if (ah->ah_version >= AR5K_AR5211) {
ath5k_hw_reg_write(ah, AR5K_KEYTABLE_TYPE_NULL,
AR5K_KEYTABLE_TYPE(entry));

--
1.6.2.4


2009-04-26 02:01:35

by Bob Copeland

[permalink] [raw]
Subject: Re: [PATCH 1/1] ath5k: 5211, don't crypt every protected frame

On Sat, Apr 25, 2009 at 02:09:23PM +0200, Jiri Slaby wrote:
> Hi guys,
> do you remember some 5211 HW which didn't work with this?
> --
>
> Set null key type even on ar5211, otherwise it en/decrypts every frame with
> protected bit set which renders the card unusable on encrypted networks.

Not me. I don't have the hardware, so I would say if your patch is known
to work on a 5211 then we go with it.

--
Bob Copeland %% http://www.bobcopeland.com

2009-04-26 10:38:46

by Jiri Slaby

[permalink] [raw]
Subject: Re: [PATCH 1/1] ath5k: 5211, don't crypt every protected frame

On 04/26/2009 04:00 AM, Bob Copeland wrote:
> On Sat, Apr 25, 2009 at 02:09:23PM +0200, Jiri Slaby wrote:
>> Hi guys,
>> do you remember some 5211 HW which didn't work with this?
>> --
>>
>> Set null key type even on ar5211, otherwise it en/decrypts every frame with
>> protected bit set which renders the card unusable on encrypted networks.
>
> Not me. I don't have the hardware, so I would say if your patch is known
> to work on a 5211 then we go with it.

Ok, thanks. Of course the HW I used (IBM T40 Thinkpad) needs the patch ;).

2009-04-26 14:13:51

by Nick Kossifidis

[permalink] [raw]
Subject: Re: [PATCH 1/1] ath5k: 5211, don't crypt every protected frame

2009/4/26 Jiri Slaby <[email protected]>:
> On 04/26/2009 04:00 AM, Bob Copeland wrote:
>> On Sat, Apr 25, 2009 at 02:09:23PM +0200, Jiri Slaby wrote:
>>> Hi guys,
>>> do you remember some 5211 HW which didn't work with this?
>>> --
>>>
>>> Set null key type even on ar5211, otherwise it en/decrypts every frame with
>>> protected bit set which renders the card unusable on encrypted networks.
>>
>> Not me.  I don't have the hardware, so I would say if your patch is known
>> to work on a 5211 then we go with it.
>
> Ok, thanks. Of course the HW I used (IBM T40 Thinkpad) needs the patch ;).
>

Acked-by: Nick Kossifidis <[email protected]>

--
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick