2018-05-02 11:30:37

by Michael Ellerman

Subject: [PATCH] tracing: Remove PPC32 wart from config TRACING_SUPPORT

config TRACING_SUPPORT has an exception for PPC32, because PPC32
didn't have irqflags tracing support.

But that hasn't been true since commit 5d38902c4838 ("powerpc: Add
irqtrace support for 32-bit powerpc") (Jun 2009).

So remove the exception for PPC32 and the comment.

Signed-off-by: Michael Ellerman <[email protected]>
---
kernel/trace/Kconfig | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index c4f0f2e4126e..dd6c0a2ad969 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -110,11 +110,7 @@ config GENERIC_TRACER
#
config TRACING_SUPPORT
bool
- # PPC32 has no irqflags tracing support, but it can use most of the
- # tracers anyway, they were tested to build and work. Note that new
- # exceptions to this list aren't welcomed, better implement the
- # irqflags tracing for your architecture.
- depends on TRACE_IRQFLAGS_SUPPORT || PPC32
+ depends on TRACE_IRQFLAGS_SUPPORT
depends on STACKTRACE_SUPPORT
default y

--
2.14.1

2018-05-02 12:50:44

by Steven Rostedt

Subject: Re: [PATCH] tracing: Remove PPC32 wart from config TRACING_SUPPORT

On Wed, 2 May 2018 21:29:48 +1000
Michael Ellerman <[email protected]> wrote:

> config TRACING_SUPPORT has an exception for PPC32, because PPC32
> didn't have irqflags tracing support.
>
> But that hasn't been true since commit 5d38902c4838 ("powerpc: Add
> irqtrace support for 32-bit powerpc") (Jun 2009).
>
> So remove the exception for PPC32 and the comment.
>
> Signed-off-by: Michael Ellerman <[email protected]>

Acked-by: Steven Rostedt (VMware) <[email protected]>

Feel free to take this patch through the PPC tree.

Thanks!

-- Steve

> ---
> kernel/trace/Kconfig | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index c4f0f2e4126e..dd6c0a2ad969 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -110,11 +110,7 @@ config GENERIC_TRACER
> #
> config TRACING_SUPPORT
> bool
> - # PPC32 has no irqflags tracing support, but it can use most of the
> - # tracers anyway, they were tested to build and work. Note that new
> - # exceptions to this list aren't welcomed, better implement the
> - # irqflags tracing for your architecture.
> - depends on TRACE_IRQFLAGS_SUPPORT || PPC32
> + depends on TRACE_IRQFLAGS_SUPPORT
> depends on STACKTRACE_SUPPORT
> default y
>

2018-05-08 14:54:32

by Michael Ellerman

Subject: Re: tracing: Remove PPC32 wart from config TRACING_SUPPORT

On Wed, 2018-05-02 at 11:29:48 UTC, Michael Ellerman wrote:
> config TRACING_SUPPORT has an exception for PPC32, because PPC32
> didn't have irqflags tracing support.
>
> But that hasn't been true since commit 5d38902c4838 ("powerpc: Add
> irqtrace support for 32-bit powerpc") (Jun 2009).
>
> So remove the exception for PPC32 and the comment.
>
> Signed-off-by: Michael Ellerman <[email protected]>
> Acked-by: Steven Rostedt (VMware) <[email protected]>

Applied to powerpc next.

https://git.kernel.org/powerpc/c/0ea5ee035133aeb549883ddc604a65

cheers