2018-09-24 01:42:09

by Joshua Abraham

Subject: [PATCH] usb: dwc2: remove set but unused variable

This patch removes a set but unused variable in hcd.c.

Fixes gcc warning:
variable ‘data_fifo’ set but not used [-Wunused-but-set-variable]

Signed-off-by: Joshua Abraham <[email protected]>
---
drivers/usb/dwc2/hcd.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index 2bd6e6bfc241..5f23b933cafc 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/dwc2/hcd.c
@@ -1328,14 +1328,11 @@ static void dwc2_hc_write_packet(struct dwc2_hsotg *hsotg,
u32 remaining_count;
u32 byte_count;
u32 dword_count;
- u32 __iomem *data_fifo;
u32 *data_buf = (u32 *)chan->xfer_buf;

if (dbg_hc(chan))
dev_vdbg(hsotg->dev, "%s()\n", __func__);

- data_fifo = (u32 __iomem *)(hsotg->regs + HCFIFO(chan->hc_num));
-
remaining_count = chan->xfer_len - chan->xfer_count;
if (remaining_count > chan->max_packet)
byte_count = chan->max_packet;
--
2.17.1

2018-09-24 05:49:12

by Minas Harutyunyan

Subject: Re: [PATCH] usb: dwc2: remove set but unused variable

On 9/24/2018 5:41 AM, Josh Abraham wrote:
> This patch removes a set but unused variable in hcd.c.
>
> Fixes gcc warning:
> variable ?data_fifo? set but not used [-Wunused-but-set-variable]
>
> Signed-off-by: Joshua Abraham <[email protected]>
> ---
> drivers/usb/dwc2/hcd.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
> index 2bd6e6bfc241..5f23b933cafc 100644
> --- a/drivers/usb/dwc2/hcd.c
> +++ b/drivers/usb/dwc2/hcd.c
> @@ -1328,14 +1328,11 @@ static void dwc2_hc_write_packet(struct dwc2_hsotg *hsotg,
> u32 remaining_count;
> u32 byte_count;
> u32 dword_count;
> - u32 __iomem *data_fifo;
> u32 *data_buf = (u32 *)chan->xfer_buf;
>
> if (dbg_hc(chan))
> dev_vdbg(hsotg->dev, "%s()\n", __func__);
>
> - data_fifo = (u32 __iomem *)(hsotg->regs + HCFIFO(chan->hc_num));
> -
> remaining_count = chan->xfer_len - chan->xfer_count;
> if (remaining_count > chan->max_packet)
> byte_count = chan->max_packet;
>
Acked-by: Minas Harutyunyan <[email protected]>