2004-09-02 14:09:19

by Grant Wilson

[permalink] [raw]
Subject: Problem with cdrom-range-fixes-patch in 2.6.9-rc1-mm2

Hi,
With this patch applied a CDROMVOLREAD ioctl returns EINVAL. I believe
that this is because of an error in the 'sanity check' added by the patch:

if ((buffer[offset] & 0x3f) == GPMODE_AUDIO_CTL_PAGE ||
^^
should be !=

Yours,
Grant Wilson


2004-09-03 06:42:51

by Andy Polyakov

[permalink] [raw]
Subject: Re: Problem with cdrom-range-fixes-patch in 2.6.9-rc1-mm2

Grant Wilson wrote:
> Hi,
> With this patch applied a CDROMVOLREAD ioctl returns EINVAL. I believe
> that this is because of an error in the 'sanity check' added by the patch:
>
> if ((buffer[offset] & 0x3f) == GPMODE_AUDIO_CTL_PAGE ||
> ^^
> should be !=

Yes, absolutely. It should be != GPMODE_AUDIO_CTL_PAGE. Thanks! A.