2020-01-31 12:58:08

by Peter Zijlstra

[permalink] [raw]
Subject: [PATCH -v2 00/10] Rewrite Motorola MMU page-table layout

Hi!

In order to faciliate Will's READ_ONCE() patches:

https://lkml.kernel.org/r/[email protected]

we need to fix m68k/motorola to not have a giant pmd_t. These patches do so and
are tested using ARAnyM/68040.

Michael tested the previous version on his Atari Falcon/68030.

Build tested for sun3/coldfire.

Please consider!

Changes since -v1:
- fixed sun3/coldfire build issues
- unified motorola mmu page setup
- added enum to table allocator
- moved pointer table allocator to motorola.c
- converted coldfire pgtable_t
- fixed coldfire pgd_alloc
- fixed coldfire nocache

---
arch/m68k/include/asm/mcf_pgalloc.h | 31 ++---
arch/m68k/include/asm/motorola_pgalloc.h | 74 ++++------
arch/m68k/include/asm/motorola_pgtable.h | 36 +++--
arch/m68k/include/asm/page.h | 16 ++-
arch/m68k/include/asm/pgtable_mm.h | 10 +-
arch/m68k/mm/init.c | 34 +++--
arch/m68k/mm/kmap.c | 36 +++--
arch/m68k/mm/memory.c | 103 --------------
arch/m68k/mm/motorola.c | 228 +++++++++++++++++++++++++------
9 files changed, 302 insertions(+), 266 deletions(-)



2020-01-31 13:21:09

by Greg Ungerer

[permalink] [raw]
Subject: Re: [PATCH -v2 00/10] Rewrite Motorola MMU page-table layout

Hi Peter,

On 31/1/20 10:45 pm, Peter Zijlstra wrote:
> In order to faciliate Will's READ_ONCE() patches:
>
> https://lkml.kernel.org/r/[email protected]
>
> we need to fix m68k/motorola to not have a giant pmd_t. These patches do so and
> are tested using ARAnyM/68040.
>
> Michael tested the previous version on his Atari Falcon/68030.
>
> Build tested for sun3/coldfire.

Thanks for the quick turn around. Build looks good for me too with
this new series. I will test on real hardware on Monday.

Regards
Greg


> Please consider!
>
> Changes since -v1:
> - fixed sun3/coldfire build issues
> - unified motorola mmu page setup
> - added enum to table allocator
> - moved pointer table allocator to motorola.c
> - converted coldfire pgtable_t
> - fixed coldfire pgd_alloc
> - fixed coldfire nocache
>
> ---
> arch/m68k/include/asm/mcf_pgalloc.h | 31 ++---
> arch/m68k/include/asm/motorola_pgalloc.h | 74 ++++------
> arch/m68k/include/asm/motorola_pgtable.h | 36 +++--
> arch/m68k/include/asm/page.h | 16 ++-
> arch/m68k/include/asm/pgtable_mm.h | 10 +-
> arch/m68k/mm/init.c | 34 +++--
> arch/m68k/mm/kmap.c | 36 +++--
> arch/m68k/mm/memory.c | 103 --------------
> arch/m68k/mm/motorola.c | 228 +++++++++++++++++++++++++------
> 9 files changed, 302 insertions(+), 266 deletions(-)
>
>

2020-02-01 08:08:49

by Michael Schmitz

[permalink] [raw]
Subject: Re: [PATCH -v2 00/10] Rewrite Motorola MMU page-table layout

Peter,

this version tested OK on 030, so

Tested-by; Michael Schmitz <[email protected]>

Am 01.02.2020 um 01:45 schrieb Peter Zijlstra:
> Hi!
>
> In order to faciliate Will's READ_ONCE() patches:
>
> https://lkml.kernel.org/r/[email protected]
>
> we need to fix m68k/motorola to not have a giant pmd_t. These patches do so and
> are tested using ARAnyM/68040.
>
> Michael tested the previous version on his Atari Falcon/68030.
>
> Build tested for sun3/coldfire.
>
> Please consider!
>
> Changes since -v1:
> - fixed sun3/coldfire build issues
> - unified motorola mmu page setup
> - added enum to table allocator
> - moved pointer table allocator to motorola.c
> - converted coldfire pgtable_t
> - fixed coldfire pgd_alloc
> - fixed coldfire nocache
>
> ---
> arch/m68k/include/asm/mcf_pgalloc.h | 31 ++---
> arch/m68k/include/asm/motorola_pgalloc.h | 74 ++++------
> arch/m68k/include/asm/motorola_pgtable.h | 36 +++--
> arch/m68k/include/asm/page.h | 16 ++-
> arch/m68k/include/asm/pgtable_mm.h | 10 +-
> arch/m68k/mm/init.c | 34 +++--
> arch/m68k/mm/kmap.c | 36 +++--
> arch/m68k/mm/memory.c | 103 --------------
> arch/m68k/mm/motorola.c | 228 +++++++++++++++++++++++++------
> 9 files changed, 302 insertions(+), 266 deletions(-)
>
>

2020-02-03 01:47:39

by Greg Ungerer

[permalink] [raw]
Subject: Re: [PATCH -v2 00/10] Rewrite Motorola MMU page-table layout

Hi Peter,

On 31/1/20 11:19 pm, Greg Ungerer wrote:
> On 31/1/20 10:45 pm, Peter Zijlstra wrote:
>> In order to faciliate Will's READ_ONCE() patches:
>>
>>    https://lkml.kernel.org/r/[email protected]
>>
>> we need to fix m68k/motorola to not have a giant pmd_t. These patches do so and
>> are tested using ARAnyM/68040.
>>
>> Michael tested the previous version on his Atari Falcon/68030.
>>
>> Build tested for sun3/coldfire.
>
> Thanks for the quick turn around. Build looks good for me too with
> this new series. I will test on real hardware on Monday.

So this tests good for me on real hardware. I had a look over the
ColdFire changes and I have no problems with anything.
So for the ColdFire parts:

Tested-by: Greg Ungerer <[email protected]>
Acked-by: Greg Ungerer <[email protected]>

Regards
Greg


>> Please consider!
>>
>> Changes since -v1:
>>   - fixed sun3/coldfire build issues
>>   - unified motorola mmu page setup
>>   - added enum to table allocator
>>   - moved pointer table allocator to motorola.c
>>   - converted coldfire pgtable_t
>>   - fixed coldfire pgd_alloc
>>   - fixed coldfire nocache
>>
>> ---
>>   arch/m68k/include/asm/mcf_pgalloc.h      |  31 ++---
>>   arch/m68k/include/asm/motorola_pgalloc.h |  74 ++++------
>>   arch/m68k/include/asm/motorola_pgtable.h |  36 +++--
>>   arch/m68k/include/asm/page.h             |  16 ++-
>>   arch/m68k/include/asm/pgtable_mm.h       |  10 +-
>>   arch/m68k/mm/init.c                      |  34 +++--
>>   arch/m68k/mm/kmap.c                      |  36 +++--
>>   arch/m68k/mm/memory.c                    | 103 --------------
>>   arch/m68k/mm/motorola.c                  | 228 +++++++++++++++++++++++++------
>>   9 files changed, 302 insertions(+), 266 deletions(-)
>>
>>

2020-02-03 11:19:33

by Will Deacon

[permalink] [raw]
Subject: Re: [PATCH -v2 00/10] Rewrite Motorola MMU page-table layout

On Fri, Jan 31, 2020 at 01:45:31PM +0100, Peter Zijlstra wrote:
> In order to faciliate Will's READ_ONCE() patches:
>
> https://lkml.kernel.org/r/[email protected]
>
> we need to fix m68k/motorola to not have a giant pmd_t. These patches do so and
> are tested using ARAnyM/68040.
>
> Michael tested the previous version on his Atari Falcon/68030.
>
> Build tested for sun3/coldfire.
>
> Please consider!

Apart from the two written by me:

Acked-by: Will Deacon <[email protected]>

Cheers,

Will

2020-02-10 11:17:07

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH -v2 00/10] Rewrite Motorola MMU page-table layout

Hi Peter, Will,

On Fri, Jan 31, 2020 at 1:56 PM Peter Zijlstra <[email protected]> wrote:
> In order to faciliate Will's READ_ONCE() patches:
>
> https://lkml.kernel.org/r/[email protected]
>
> we need to fix m68k/motorola to not have a giant pmd_t. These patches do so and
> are tested using ARAnyM/68040.
>
> Michael tested the previous version on his Atari Falcon/68030.
>
> Build tested for sun3/coldfire.
>
> Please consider!

Thanks, applied and queued for v5.7, using an immutable branch named
pgtable-layout-rewrite.

https://git.kernel.org/pub/scm/linux/kernel/git/geert/linux-m68k.git/log/?h=pgtable-layout-rewrite

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2020-03-09 10:17:43

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH -v2 00/10] Rewrite Motorola MMU page-table layout

Hi Peter, Will

On Mon, Feb 10, 2020 at 12:16 PM Geert Uytterhoeven
<[email protected]> wrote:
> On Fri, Jan 31, 2020 at 1:56 PM Peter Zijlstra <[email protected]> wrote:
> > In order to faciliate Will's READ_ONCE() patches:
> >
> > https://lkml.kernel.org/r/[email protected]
> >
> > we need to fix m68k/motorola to not have a giant pmd_t. These patches do so and
> > are tested using ARAnyM/68040.
> >
> > Michael tested the previous version on his Atari Falcon/68030.
> >
> > Build tested for sun3/coldfire.
> >
> > Please consider!
>
> Thanks, applied and queued for v5.7, using an immutable branch named
> pgtable-layout-rewrite.
>
> https://git.kernel.org/pub/scm/linux/kernel/git/geert/linux-m68k.git/log/?h=pgtable-layout-rewrite

Any plans to use this? Looks like it's still part of linux-next through the m68k
tree only.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2020-03-09 11:47:31

by Peter Zijlstra

[permalink] [raw]
Subject: Re: [PATCH -v2 00/10] Rewrite Motorola MMU page-table layout

On Mon, Mar 09, 2020 at 11:15:31AM +0100, Geert Uytterhoeven wrote:
> Hi Peter, Will
>
> On Mon, Feb 10, 2020 at 12:16 PM Geert Uytterhoeven
> <[email protected]> wrote:
> > On Fri, Jan 31, 2020 at 1:56 PM Peter Zijlstra <[email protected]> wrote:
> > > In order to faciliate Will's READ_ONCE() patches:
> > >
> > > https://lkml.kernel.org/r/[email protected]
> > >
> > > we need to fix m68k/motorola to not have a giant pmd_t. These patches do so and
> > > are tested using ARAnyM/68040.
> > >
> > > Michael tested the previous version on his Atari Falcon/68030.
> > >
> > > Build tested for sun3/coldfire.
> > >
> > > Please consider!
> >
> > Thanks, applied and queued for v5.7, using an immutable branch named
> > pgtable-layout-rewrite.
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/geert/linux-m68k.git/log/?h=pgtable-layout-rewrite
>
> Any plans to use this? Looks like it's still part of linux-next through the m68k
> tree only.

Argh, yes. So we ran into sparc32 also need fixups, and both me and Will
seem to have stalled on fixing that. I'll try and get back to that.