2018-03-08 09:59:54

by Arvind Yadav

[permalink] [raw]

Subject: [PATCH] pwm: sysfs: use put_device() instead of kfree()

---

Never directly free @dev after calling device_register(), even
if it returned an error! Always use put_device() to give up the
reference initialized.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/pwm/sysfs.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/pwm/sysfs.c b/drivers/pwm/sysfs.c
index 83f2b0b..7c71cdb 100644
--- a/drivers/pwm/sysfs.c
+++ b/drivers/pwm/sysfs.c
@@ -273,7 +273,8 @@ static int pwm_export_child(struct device *parent, struct pwm_device *pwm)
ret = device_register(&export->child);
if (ret) {
clear_bit(PWMF_EXPORTED, &pwm->flags);
- kfree(export);
+ put_device(&export->child);
+ export = NULL;
return ret;
}

--
1.9.1

2018-03-27 23:21:32

by Thierry Reding

[permalink] [raw]

Subject: Re: [PATCH] pwm: sysfs: use put_device() instead of kfree()

---

On Thu, Mar 08, 2018 at 03:27:37PM +0530, Arvind Yadav wrote:
> Never directly free @dev after calling device_register(), even
> if it returned an error! Always use put_device() to give up the
> reference initialized.
>
> Signed-off-by: Arvind Yadav <[email protected]>
> ---
> drivers/pwm/sysfs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)

Applied, thanks.

Thierry

---

Attachments:

(No filename) (406.00 B)
signature.asc (849.00 B)
Download all attachments