2005-01-04 14:52:32

by Liam Girdwood

[permalink] [raw]
Subject: [PATCH 2/2] AC97 plugin suspend/resume

This patch sets suspend and resume to NULL in the ad1980 plugin.

Signed-off-by: Liam Girdwood <[email protected]>

Liam


Attachments:
ac97_plugin_ad1980.diff (309.00 B)

2005-01-04 15:07:32

by Brian Gerst

[permalink] [raw]
Subject: Re: [PATCH 2/2] AC97 plugin suspend/resume

Liam Girdwood wrote:
> This patch sets suspend and resume to NULL in the ad1980 plugin.
>
> Signed-off-by: Liam Girdwood <[email protected]>
>
> Liam
>
>
> ------------------------------------------------------------------------
>
> --- a/sound/oss/ac97_plugin_ad1980.c 2004-12-24 21:33:48.000000000 +0000
> +++ b/sound/oss/ac97_plugin_ad1980.c 2005-01-04 14:15:40.000000000 +0000
> @@ -89,6 +89,8 @@
> .name = "AD1980 example",
> .probe = ad1980_probe,
> .remove = __devexit_p(ad1980_remove),
> + .suspend = NULL,
> + .resume = NULL,
> };
>
> /**

There is really no reason to add these fields if they are NULL. Zero
(or NULL for pointers) is the default for all unspecified fields, and it
is kernel convention to use this feature to reduce clutter.

--
Brian Gerst

2005-01-04 15:29:56

by Liam Girdwood

[permalink] [raw]
Subject: Re: [PATCH 2/2] AC97 plugin suspend/resume

On Tue, 2005-01-04 at 15:07, Brian Gerst wrote:

> There is really no reason to add these fields if they are NULL. Zero
> (or NULL for pointers) is the default for all unspecified fields, and it
> is kernel convention to use this feature to reduce clutter.
>

Ok, patch 2/2 can be safely ignored. It was added for clarity.

Liam