2005-01-12 13:21:19

by Pavel Machek

[permalink] [raw]
Subject: comment/whitespace updates

Hi!

This cleans few comments/formatting. Please apply,

Signed-off-by: Pavel Machek <[email protected]>

Pavel

--- clean/arch/i386/kernel/acpi/wakeup.S 2004-12-25 13:34:57.000000000 +0100
+++ linux/arch/i386/kernel/acpi/wakeup.S 2004-12-25 15:51:04.000000000 +0100
@@ -278,7 +294,7 @@
movl %edi, saved_context_edi
pushfl ; popl saved_context_eflags

- movl $ret_point,saved_eip
+ movl $ret_point, saved_eip
ret


@@ -295,7 +311,7 @@
call save_registers
pushl $3
call acpi_enter_sleep_state
- addl $4,%esp
+ addl $4, %esp
ret
.p2align 4,,7
ret_point:
--- clean/drivers/acpi/events/evgpeblk.c 2004-12-25 13:34:58.000000000 +0100
+++ linux/drivers/acpi/events/evgpeblk.c 2004-12-25 15:51:15.000000000 +0100
@@ -925,7 +925,7 @@

/*
* Runtime option: Should Wake GPEs be enabled at runtime? The default
- * is No,they should only be enabled just as the machine goes to sleep.
+ * is No, they should only be enabled just as the machine goes to sleep.
*/
if (acpi_gbl_leave_wake_gpes_disabled) {
/*
--- clean/include/linux/page-flags.h 2005-01-12 11:07:40.000000000 +0100
+++ linux/include/linux/page-flags.h 2005-01-12 11:25:19.000000000 +0100
@@ -74,7 +74,7 @@
#define PG_swapcache 16 /* Swap page: swp_entry_t in private */
#define PG_mappedtodisk 17 /* Has blocks allocated on-disk */
#define PG_reclaim 18 /* To be reclaimed asap */
-#define PG_nosave_free 19 /* Free, should not be written */
+#define PG_nosave_free 19 /* Page is free, and should not be written by swsusp */


/*

--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!


2005-01-12 14:49:56

by Matthias-Christian Ott

[permalink] [raw]
Subject: Re: comment/whitespace updates

Pavel Machek wrote:

>Hi!
>
>This cleans few comments/formatting. Please apply,
>
>Signed-off-by: Pavel Machek <[email protected]>
>
> Pavel
>
>--- clean/arch/i386/kernel/acpi/wakeup.S 2004-12-25 13:34:57.000000000 +0100
>+++ linux/arch/i386/kernel/acpi/wakeup.S 2004-12-25 15:51:04.000000000 +0100
>@@ -278,7 +294,7 @@
> movl %edi, saved_context_edi
> pushfl ; popl saved_context_eflags
>
>- movl $ret_point,saved_eip
>+ movl $ret_point, saved_eip
> ret
>
>
>@@ -295,7 +311,7 @@
> call save_registers
> pushl $3
> call acpi_enter_sleep_state
>- addl $4,%esp
>+ addl $4, %esp
> ret
> .p2align 4,,7
> ret_point:
>--- clean/drivers/acpi/events/evgpeblk.c 2004-12-25 13:34:58.000000000 +0100
>+++ linux/drivers/acpi/events/evgpeblk.c 2004-12-25 15:51:15.000000000 +0100
>@@ -925,7 +925,7 @@
>
> /*
> * Runtime option: Should Wake GPEs be enabled at runtime? The default
>- * is No,they should only be enabled just as the machine goes to sleep.
>+ * is No, they should only be enabled just as the machine goes to sleep.
> */
> if (acpi_gbl_leave_wake_gpes_disabled) {
> /*
>--- clean/include/linux/page-flags.h 2005-01-12 11:07:40.000000000 +0100
>+++ linux/include/linux/page-flags.h 2005-01-12 11:25:19.000000000 +0100
>@@ -74,7 +74,7 @@
> #define PG_swapcache 16 /* Swap page: swp_entry_t in private */
> #define PG_mappedtodisk 17 /* Has blocks allocated on-disk */
> #define PG_reclaim 18 /* To be reclaimed asap */
>-#define PG_nosave_free 19 /* Free, should not be written */
>+#define PG_nosave_free 19 /* Page is free, and should not be written by swsusp */
>
>
> /*
>
>
>
Very useful. :-)
Why do you send such a nonsense to mailinglist? It's poor.

Matthias-Christian Ott

2005-01-13 17:15:40

by Stefan Seyfried

[permalink] [raw]
Subject: Re: comment/whitespace updates

Matthias-Christian Ott wrote:

> Why do you send such a nonsense to mailinglist? It's poor.
>
> Matthias-Christian Ott

Read Documentation/CodingStyle. Then "Try again Player 1"

Stefan