2005-01-22 13:48:56

by Matthias-Christian Ott

[permalink] [raw]
Subject: [PATCH]: speedstep-lib: fix frequency multiplier for Pentium4 models 0&1

The Pentium4 models 0&1 have a longer MSR_EBC_FREQUENCY_ID register as
the models 2&3, so the bit shift must be bigger.

Signed-off-by: Matthias-Christian Ott <[email protected]>

--- linux-bk/arch/i386/kernel/cpu/cpufreq/speedstep-lib.c.orig
2005-01-21 13:55:37.000000000 +0100
+++ linux-bk/arch/i386/kernel/cpu/cpufreq/speedstep-lib.c 2005-01-22
10:58:34.000000000 +0100
@@ -160,7 +160,14 @@
printk(KERN_DEBUG "speedstep-lib: couldn't detect FSB speed.
Please send an e-mail to <[email protected]>\n");

/* Multiplier. */
- mult = msr_lo >> 24;
+ if (c->x86_model < 2)
+ {
+ mult = msr_lo >> 27;
+ }
+ else
+ {
+ mult = msr_lo >> 24;
+ }

dprintk("P4 - FSB %u kHz; Multiplier %u; Speed %u kHz\n", fsb,
mult, (fsb * mult));




2005-01-22 14:24:16

by Arjan van de Ven

[permalink] [raw]
Subject: Re: [PATCH]: speedstep-lib: fix frequency multiplier for Pentium4 models 0&1


On Sat, Jan 22, 2005 at 02:48:52PM +0100, Matthias-Christian Ott wrote:
> The Pentium4 models 0&1 have a longer MSR_EBC_FREQUENCY_ID register as
> the models 2&3, so the bit shift must be bigger.

I would feel safer if this checked that it was actually a p4 as well...

2005-01-22 14:33:28

by Matthias-Christian Ott

[permalink] [raw]
Subject: Re: [PATCH]: speedstep-lib: fix frequency multiplier for Pentium4 models 0&1

Arjan van de Ven wrote:

>On Sat, Jan 22, 2005 at 02:48:52PM +0100, Matthias-Christian Ott wrote:
>
>
>>The Pentium4 models 0&1 have a longer MSR_EBC_FREQUENCY_ID register as
>>the models 2&3, so the bit shift must be bigger.
>>
>>
>
>I would feel safer if this checked that it was actually a p4 as well...
>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to [email protected]
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
>
>
>
Hi!
If mean my CPU, it's a pentium4 model 1 and the patch is checked with it.
All other tests which check if it's a pentium4 are performed by other
instances of the cpufreq driver.

Matthias-Christian Ott