Hi!
It boots ok (unlike mainline -- I'm debugging that), and I can suspend
and resume... but then cursor in X is moving and I can talk to
applications cached in memory, but any access to disk hangs.
Any ideas?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Hi!
> It boots ok (unlike mainline -- I'm debugging that), and I can suspend
> and resume... but then cursor in X is moving and I can talk to
> applications cached in memory, but any access to disk hangs.
Mainline problem was identified.
But resume is still broken. I took advantage of fact that I can still
do cached commands, and got complete dmesg. I'm attaching it.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Hi!
> > It boots ok (unlike mainline -- I'm debugging that), and I can suspend
> > and resume... but then cursor in X is moving and I can talk to
> > applications cached in memory, but any access to disk hangs.
>
> Mainline problem was identified.
>
> But resume is still broken. I took advantage of fact that I can still
> do cached commands, and got complete dmesg. I'm attaching it.
Still broken in 0418. Ideas would be welcome at this point.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On 4/23/19 4:22 AM, Pavel Machek wrote:
> Hi!
>
>>> It boots ok (unlike mainline -- I'm debugging that), and I can suspend
>>> and resume... but then cursor in X is moving and I can talk to
>>> applications cached in memory, but any access to disk hangs.
>>
>> Mainline problem was identified.
>>
>> But resume is still broken. I took advantage of fact that I can still
>> do cached commands, and got complete dmesg. I'm attaching it.
>
> Still broken in 0418. Ideas would be welcome at this point.
Bisect it?
--
Jens Axboe
On 4/23/19 3:22 AM, Pavel Machek wrote:
>>> It boots ok (unlike mainline -- I'm debugging that), and I can suspend
>>> and resume... but then cursor in X is moving and I can talk to
>>> applications cached in memory, but any access to disk hangs.
>>
>> Mainline problem was identified.
>>
>> But resume is still broken. I took advantage of fact that I can still
>> do cached commands, and got complete dmesg. I'm attaching it.
>
> Still broken in 0418. Ideas would be welcome at this point.
Have you already tried the debugging steps explained in
Documentation/power to obtain more information about the nature of the
suspend/resume problem?
Bart.
On Tue 2019-04-23 07:55:05, Jens Axboe wrote:
> On 4/23/19 4:22 AM, Pavel Machek wrote:
> > Hi!
> >
> >>> It boots ok (unlike mainline -- I'm debugging that), and I can suspend
> >>> and resume... but then cursor in X is moving and I can talk to
> >>> applications cached in memory, but any access to disk hangs.
> >>
> >> Mainline problem was identified.
> >>
> >> But resume is still broken. I took advantage of fact that I can still
> >> do cached commands, and got complete dmesg. I'm attaching it.
> >
> > Still broken in 0418. Ideas would be welcome at this point.
>
> Bisect it?
Before I start heavy debugging, it would be interesting to
know... does suspend/resume work for you in -next?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On Tue 2019-04-23 07:55:05, Jens Axboe wrote:
> On 4/23/19 4:22 AM, Pavel Machek wrote:
> > Hi!
> >
> >>> It boots ok (unlike mainline -- I'm debugging that), and I can suspend
> >>> and resume... but then cursor in X is moving and I can talk to
> >>> applications cached in memory, but any access to disk hangs.
> >>
> >> Mainline problem was identified.
> >>
> >> But resume is still broken. I took advantage of fact that I can still
> >> do cached commands, and got complete dmesg. I'm attaching it.
> >
> > Still broken in 0418. Ideas would be welcome at this point.
>
> Bisect it?
commit fdbbda7b3a0622fcfe630238d0bf6c57c4ba3663
Merge: 3c442d5 6c88d73
Author: Jens Axboe <[email protected]>
Date: Mon Apr 22 13:57:36 2019 -0600
Works ok. So... block is not responsible.
Let me check
commit 91b112cf3b599f06f1e810cfedf37023f25d5588
Merge: fb2c4a8 e32d939
Author: Rafael J. Wysocki <[email protected]>
Date: Mon Apr 22 01:52:48 2019 +0200
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On Wed 2019-04-24 11:54:31, Pavel Machek wrote:
> On Tue 2019-04-23 07:55:05, Jens Axboe wrote:
> > On 4/23/19 4:22 AM, Pavel Machek wrote:
> > > Hi!
> > >
> > >>> It boots ok (unlike mainline -- I'm debugging that), and I can suspend
> > >>> and resume... but then cursor in X is moving and I can talk to
> > >>> applications cached in memory, but any access to disk hangs.
> > >>
> > >> Mainline problem was identified.
> > >>
> > >> But resume is still broken. I took advantage of fact that I can still
> > >> do cached commands, and got complete dmesg. I'm attaching it.
> > >
> > > Still broken in 0418. Ideas would be welcome at this point.
> >
> > Bisect it?
>
> commit fdbbda7b3a0622fcfe630238d0bf6c57c4ba3663
> Merge: 3c442d5 6c88d73
> Author: Jens Axboe <[email protected]>
> Date: Mon Apr 22 13:57:36 2019 -0600
>
> Works ok. So... block is not responsible.
>
> Let me check
>
> commit 91b112cf3b599f06f1e810cfedf37023f25d5588
> Merge: fb2c4a8 e32d939
> Author: Rafael J. Wysocki <[email protected]>
> Date: Mon Apr 22 01:52:48 2019 +0200
Suspend/resume ok, so pm not responsible. Let me check next-20190423.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On Tue 2019-04-23 07:09:42, Bart Van Assche wrote:
> On 4/23/19 3:22 AM, Pavel Machek wrote:
> >>> It boots ok (unlike mainline -- I'm debugging that), and I can suspend
> >>> and resume... but then cursor in X is moving and I can talk to
> >>> applications cached in memory, but any access to disk hangs.
> >>
> >> Mainline problem was identified.
> >>
> >> But resume is still broken. I took advantage of fact that I can still
> >> do cached commands, and got complete dmesg. I'm attaching it.
> >
> > Still broken in 0418. Ideas would be welcome at this point.
>
> Have you already tried the debugging steps explained in
> Documentation/power to obtain more information about the nature of the
> suspend/resume problem?
That won't help, as system resumes ok, then disk hangs.
Does it work for you?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Hi!
> Not block, but it seems scsi subsystem is:
commit 21e6ba3f0e0257cce1a226c1f15e0a8ba4338ca3
Author: Bart Van Assche <[email protected]>
Date: Wed Mar 20 13:09:19 2019 -0700
scsi: sd: Rely on the driver core for asynchronous probing
As explained during the 2018 LSF/MM session about increasing SCSI
disk
probing concurrency, the problems with the current probing
approach are as
Seems to be responsible. Full log attached.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On Wed 2019-04-24 22:48:32, Pavel Machek wrote:
> Hi!
>
> > Not block, but it seems scsi subsystem is:
>
> commit 21e6ba3f0e0257cce1a226c1f15e0a8ba4338ca3
> Author: Bart Van Assche <[email protected]>
> Date: Wed Mar 20 13:09:19 2019 -0700
>
> scsi: sd: Rely on the driver core for asynchronous probing
>
> As explained during the 2018 LSF/MM session about increasing SCSI
> disk
> probing concurrency, the problems with the current probing
> approach are as
>
> Seems to be responsible. Full log attached.
Unfortunately, that one does not revert cleanly on top of -next.
Any ideas what is wrong?
Does suspend/resume work for you?
I can test patches.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On Wed 2019-04-24 13:56:01, Bart Van Assche wrote:
> On Wed, 2019-04-24 at 22:51 +0200, Pavel Machek wrote:
> > Unfortunately, that one does not revert cleanly on top of -next.
>
> Can you try the following:
>
> git revert d16ece577bf2cee7f94bab75a0d967bcb89dd2a7 &&
> git revert 21e6ba3f0e0257cce1a226c1f15e0a8ba4338ca3
>
> I will see whether I can come up with a better way to analyze what is
> going on. I had not expected that these patches would cause any suspend/
> resume problems.
Not even d16ece reverts:
pavel@duo:/data/l/linux-next-32$ git show | head -3
commit 76c938fcaa4b4a5d8f05fa907925d5043834964e
Author: Stephen Rothwell <[email protected]>
Date: Tue Apr 23 20:24:59 2019 +1000
pavel@duo:/data/l/linux-next-32$ git revert
d16ece577bf2cee7f94bab75a0d967bcb89dd2a7
error: could not revert d16ece5... scsi: sd: Inline sd_probe_part2()
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
On Wed, 2019-04-24 at 22:51 +-0200, Pavel Machek wrote:
+AD4 Unfortunately, that one does not revert cleanly on top of -next.
Can you try the following:
git revert d16ece577bf2cee7f94bab75a0d967bcb89dd2a7 +ACYAJg
git revert 21e6ba3f0e0257cce1a226c1f15e0a8ba4338ca3
I will see whether I can come up with a better way to analyze what is
going on. I had not expected that these patches would cause any suspend/
resume problems.
Bart.
On Wed, 2019-04-24 at 12:17 +-0200, Pavel Machek wrote:
+AD4 On Tue 2019-04-23 07:09:42, Bart Van Assche wrote:
+AD4 +AD4 On 4/23/19 3:22 AM, Pavel Machek wrote:
+AD4 +AD4 +AD4 +AD4 +AD4 It boots ok (unlike mainline -- I'm debugging that), and I can suspend
+AD4 +AD4 +AD4 +AD4 +AD4 and resume... but then cursor in X is moving and I can talk to
+AD4 +AD4 +AD4 +AD4 +AD4 applications cached in memory, but any access to disk hangs.
+AD4 +AD4 +AD4 +AD4
+AD4 +AD4 +AD4 +AD4 Mainline problem was identified.
+AD4 +AD4 +AD4 +AD4
+AD4 +AD4 +AD4 +AD4 But resume is still broken. I took advantage of fact that I can still
+AD4 +AD4 +AD4 +AD4 do cached commands, and got complete dmesg. I'm attaching it.
+AD4 +AD4 +AD4
+AD4 +AD4 +AD4 Still broken in 0418. Ideas would be welcome at this point.
+AD4 +AD4
+AD4 +AD4 Have you already tried the debugging steps explained in
+AD4 +AD4 Documentation/power to obtain more information about the nature of the
+AD4 +AD4 suspend/resume problem?
+AD4
+AD4 That won't help, as system resumes ok, then disk hangs.
+AD4
+AD4 Does it work for you?
Both +ACI-systemctl hibernate+ACI and +ACI-systemctl suspend+ACI work perfectly with the
next-20190424 kernel on my laptop (a Dell Precision laptop).
Bart.
On Wed 2019-04-24 12:48:50, Pavel Machek wrote:
> On Wed 2019-04-24 11:54:31, Pavel Machek wrote:
> > On Tue 2019-04-23 07:55:05, Jens Axboe wrote:
> > > On 4/23/19 4:22 AM, Pavel Machek wrote:
> > > > Hi!
> > > >
> > > >>> It boots ok (unlike mainline -- I'm debugging that), and I can suspend
> > > >>> and resume... but then cursor in X is moving and I can talk to
> > > >>> applications cached in memory, but any access to disk hangs.
> > > >>
> > > >> Mainline problem was identified.
> > > >>
> > > >> But resume is still broken. I took advantage of fact that I can still
> > > >> do cached commands, and got complete dmesg. I'm attaching it.
> > > >
> > > > Still broken in 0418. Ideas would be welcome at this point.
> > >
> > > Bisect it?
> >
> > commit fdbbda7b3a0622fcfe630238d0bf6c57c4ba3663
> > Merge: 3c442d5 6c88d73
> > Author: Jens Axboe <[email protected]>
> > Date: Mon Apr 22 13:57:36 2019 -0600
> >
> > Works ok. So... block is not responsible.
> >
> > Let me check
> >
> > commit 91b112cf3b599f06f1e810cfedf37023f25d5588
> > Merge: fb2c4a8 e32d939
> > Author: Rafael J. Wysocki <[email protected]>
> > Date: Mon Apr 22 01:52:48 2019 +0200
>
> Suspend/resume ok, so pm not responsible. Let me check next-20190423.
Not block, but it seems scsi subsystem is:
pavel@duo:/data/l/linux-next-32$ git bisect log
# bad: [76c938fcaa4b4a5d8f05fa907925d5043834964e] Add linux-next
specific files for 20190423
# good: [7142eaa58b49d9de492ccc16d48df7c488a5fbb6] Merge tag
'mips_fixes_5.1_3' of
git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux
git bisect start 'next-20190423'
'7142eaa58b49d9de492ccc16d48df7c488a5fbb6'
# good: [ed04f675fa2c22316d7b57bea1258a18a47537ea] Merge
remote-tracking branch 'crypto/master'
git bisect good ed04f675fa2c22316d7b57bea1258a18a47537ea
# good: [4a99e5b3463f5c936540958914bff57ec50ac1e0] Merge
remote-tracking branch 'spi/for-next'
git bisect good 4a99e5b3463f5c936540958914bff57ec50ac1e0
# good: [61cabbda2a7e966b689a6791050ad675e6dff274] Merge
remote-tracking branch 'staging/staging-next'
git bisect good 61cabbda2a7e966b689a6791050ad675e6dff274
# bad: [c8f0c2453f64529035e25fbfb9de9d24e98baff7] Merge
remote-tracking branch 'coresight/next'
git bisect bad c8f0c2453f64529035e25fbfb9de9d24e98baff7
# bad: [6fb251c6f174d3cc571391baa9f6e57fff505446] Merge branch 'misc'
into for-next
git bisect bad 6fb251c6f174d3cc571391baa9f6e57fff505446
# bad: [78a8ab3cc0f95a66c8fb2429030289103de173e7] scsi: qedf: fixup
bit operations
git bisect bad 78a8ab3cc0f95a66c8fb2429030289103de173e7
# good: [c0327e67ecd86e88f5bc5fd54bfdf9b422a1c93f] scsi: core: remove
the scsi_ioctl_reset export
git bisect good c0327e67ecd86e88f5bc5fd54bfdf9b422a1c93f
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On 4/25/19 12:33 AM, Pavel Machek wrote:
> On Wed 2019-04-24 13:56:01, Bart Van Assche wrote:
>> On Wed, 2019-04-24 at 22:51 +0200, Pavel Machek wrote:
>>> Unfortunately, that one does not revert cleanly on top of -next.
>>
>> Can you try the following:
>>
>> git revert d16ece577bf2cee7f94bab75a0d967bcb89dd2a7 &&
>> git revert 21e6ba3f0e0257cce1a226c1f15e0a8ba4338ca3
>>
>> I will see whether I can come up with a better way to analyze what is
>> going on. I had not expected that these patches would cause any suspend/
>> resume problems.
>
> Not even d16ece reverts:
>
> pavel@duo:/data/l/linux-next-32$ git show | head -3
> commit 76c938fcaa4b4a5d8f05fa907925d5043834964e
> Author: Stephen Rothwell <[email protected]>
> Date: Tue Apr 23 20:24:59 2019 +1000
> pavel@duo:/data/l/linux-next-32$ git revert
> d16ece577bf2cee7f94bab75a0d967bcb89dd2a7
> error: could not revert d16ece5... scsi: sd: Inline sd_probe_part2()
> hint: after resolving the conflicts, mark the corrected paths
> hint: with 'git add <paths>' or 'git rm <paths>'
> hint: and commit the result with 'git commit'
There has been a non-trivial merge between the block and scsi trees in
linux-next. That's probably what prevents these patches to revert
cleanly. How about performing the following tests:
* Build, boot and test Martin's latest for-5.2 branch
(git://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git; branch
5.2/scsi-queue).
* If suspend/resume does not work reliably with that branch, revert the
two patches above, rebuild, reboot and retest.
Thanks,
Bart.
On Thu 2019-04-25 06:35:58, Bart Van Assche wrote:
> On 4/25/19 12:33 AM, Pavel Machek wrote:
> > On Wed 2019-04-24 13:56:01, Bart Van Assche wrote:
> >> On Wed, 2019-04-24 at 22:51 +0200, Pavel Machek wrote:
> >>> Unfortunately, that one does not revert cleanly on top of -next.
> >>
> >> Can you try the following:
> >>
> >> git revert d16ece577bf2cee7f94bab75a0d967bcb89dd2a7 &&
> >> git revert 21e6ba3f0e0257cce1a226c1f15e0a8ba4338ca3
> >>
> >> I will see whether I can come up with a better way to analyze what is
> >> going on. I had not expected that these patches would cause any suspend/
> >> resume problems.
> >
> > Not even d16ece reverts:
> >
> > pavel@duo:/data/l/linux-next-32$ git show | head -3
> > commit 76c938fcaa4b4a5d8f05fa907925d5043834964e
> > Author: Stephen Rothwell <[email protected]>
> > Date: Tue Apr 23 20:24:59 2019 +1000
> > pavel@duo:/data/l/linux-next-32$ git revert
> > d16ece577bf2cee7f94bab75a0d967bcb89dd2a7
> > error: could not revert d16ece5... scsi: sd: Inline sd_probe_part2()
> > hint: after resolving the conflicts, mark the corrected paths
> > hint: with 'git add <paths>' or 'git rm <paths>'
> > hint: and commit the result with 'git commit'
>
> There has been a non-trivial merge between the block and scsi trees in
> linux-next. That's probably what prevents these patches to revert
> cleanly. How about performing the following tests:
> * Build, boot and test Martin's latest for-5.2 branch
> (git://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git; branch
> 5.2/scsi-queue).
Ok, so that's commit a7634b6f7cbbdc6efcf772e080a6fe845d1f6161
. Suspend/resume is broken there.
> * If suspend/resume does not work reliably with that branch, revert the
> two patches above, rebuild, reboot and retest.
pavel@duo:/data/l/linux-next-32$ git show
commit a7634b6f7cbbdc6efcf772e080a6fe845d1f6161
Author: Colin Ian King <[email protected]>
pavel@duo:/data/l/linux-next-32$ git revert
d16ece577bf2cee7f94bab75a0d967bcb89dd2a7
Editing file: /data/fast/l/linux-next-32/.git/COMMIT_EDITMSG
1026
?
[detached HEAD 916db0d] Revert "scsi: sd: Inline sd_probe_part2()"
1 file changed, 58 insertions(+), 43 deletions(-)
pavel@duo:/data/l/linux-next-32$ git revert
21e6ba3f0e0257cce1a226c1f15e0a8ba4338ca3
Editing file: /data/fast/l/linux-next-32/.git/COMMIT_EDITMSG
1163
?
[detached HEAD ac8d625] Revert "scsi: sd: Rely on the driver core for
asynchronous probing"
4 files changed, 47 insertions(+), 5 deletions(-)
And reverting those two indeed fixes it:
Checking version...
version is Linux amd 5.1.0-rc1autobisect1556274387+ #261 SMP Fri Apr
26 12:27:12 CEST 2019 i686 GNU/Linux
Running test...
Result is [ TEST SUCCESS ]
Test said TEST SUCCESS
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
On Fri, 2019-04-26 at 12:32 +-0200, Pavel Machek wrote:
+AD4 +AFs-detached HEAD 916db0d+AF0 Revert +ACI-scsi: sd: Inline sd+AF8-probe+AF8-part2()+ACI
+AD4 1 file changed, 58 insertions(+-), 43 deletions(-)
+AD4 pavel+AEA-duo:/data/l/linux-next-32+ACQ git revert
+AD4 21e6ba3f0e0257cce1a226c1f15e0a8ba4338ca3
+AD4 Editing file: /data/fast/l/linux-next-32/.git/COMMIT+AF8-EDITMSG
+AD4 1163
+AD4 ?
+AD4 +AFs-detached HEAD ac8d625+AF0 Revert +ACI-scsi: sd: Rely on the driver core for
+AD4 asynchronous probing+ACI
+AD4 4 files changed, 47 insertions(+-), 5 deletions(-)
+AD4
+AD4
+AD4 And reverting those two indeed fixes it:
+AD4
+AD4 Checking version...
+AD4 version is Linux amd 5.1.0-rc1autobisect1556274387+- +ACM-261 SMP Fri Apr
+AD4 26 12:27:12 CEST 2019 i686 GNU/Linux
+AD4 Running test...
+AD4 Result is +AFs TEST SUCCESS +AF0
+AD4 Test said TEST SUCCESS
Can you share your config file? I hope that will allow me to reproduce this
issue.
Thanks,
Bart.
On Fri 2019-04-26 07:58:49, Bart Van Assche wrote:
> On Fri, 2019-04-26 at 12:32 +0200, Pavel Machek wrote:
> > [detached HEAD 916db0d] Revert "scsi: sd: Inline sd_probe_part2()"
> > 1 file changed, 58 insertions(+), 43 deletions(-)
> > pavel@duo:/data/l/linux-next-32$ git revert
> > 21e6ba3f0e0257cce1a226c1f15e0a8ba4338ca3
> > Editing file: /data/fast/l/linux-next-32/.git/COMMIT_EDITMSG
> > 1163
> > ?
> > [detached HEAD ac8d625] Revert "scsi: sd: Rely on the driver core for
> > asynchronous probing"
> > 4 files changed, 47 insertions(+), 5 deletions(-)
> >
> >
> > And reverting those two indeed fixes it:
> >
> > Checking version...
> > version is Linux amd 5.1.0-rc1autobisect1556274387+ #261 SMP Fri Apr
> > 26 12:27:12 CEST 2019 i686 GNU/Linux
> > Running test...
> > Result is [ TEST SUCCESS ]
> > Test said TEST SUCCESS
>
> Can you share your config file? I hope that will allow me to reproduce this
> issue.
Here you go. You may want to google Thinkpad X60. Its best notebook
ever made, but... :-).
Pavel
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany