2005-01-31 23:44:01

by Adrian Bunk

Subject: [2.6 patch] i386/mach-default/topology.c: make cpu_devices static

This patch makes a needlessly global struct static.

Signed-off-by: Adrian Bunk <[email protected]>

---

arch/i386/mach-default/topology.c | 2 +-
include/asm-i386/cpu.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)

This patch was already sent on:
- 16 Jan 2005

--- linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h.old 2005-01-16 05:41:55.000000000 +0100
+++ linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h 2005-01-16 05:42:09.000000000 +0100
@@ -12,7 +12,6 @@
struct i386_cpu {
struct cpu cpu;
};
-extern struct i386_cpu cpu_devices[NR_CPUS];
extern int arch_register_cpu(int num);
#ifdef CONFIG_HOTPLUG_CPU
extern void arch_unregister_cpu(int);
--- linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c.old 2005-01-16 05:42:18.000000000 +0100
+++ linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c 2005-01-16 05:42:43.000000000 +0100
@@ -30,7 +30,7 @@
#include <linux/nodemask.h>
#include <asm/cpu.h>

-struct i386_cpu cpu_devices[NR_CPUS];
+static struct i386_cpu cpu_devices[NR_CPUS];

int arch_register_cpu(int num){
struct node *parent = NULL;

2005-02-02 23:19:00

by Matthew Dobson

Subject: Re: [2.6 patch] i386/mach-default/topology.c: make cpu_devices static

Looks good to me!

Acked-by: Matthew Dobson <[email protected]>

Adrian Bunk wrote:

>This patch makes a needlessly global struct static.
>
>Signed-off-by: Adrian Bunk <[email protected]>
>
>---
>
> arch/i386/mach-default/topology.c | 2 +-
> include/asm-i386/cpu.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
>This patch was already sent on:
>- 16 Jan 2005
>
>--- linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h.old 2005-01-16 05:41:55.000000000 +0100
>+++ linux-2.6.11-rc1-mm1-full/include/asm-i386/cpu.h 2005-01-16 05:42:09.000000000 +0100
>@@ -12,7 +12,6 @@
> struct i386_cpu {
> struct cpu cpu;
> };
>-extern struct i386_cpu cpu_devices[NR_CPUS];
> extern int arch_register_cpu(int num);
> #ifdef CONFIG_HOTPLUG_CPU
> extern void arch_unregister_cpu(int);
>--- linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c.old 2005-01-16 05:42:18.000000000 +0100
>+++ linux-2.6.11-rc1-mm1-full/arch/i386/mach-default/topology.c 2005-01-16 05:42:43.000000000 +0100
>@@ -30,7 +30,7 @@
> #include <linux/nodemask.h>
> #include <asm/cpu.h>
>
>-struct i386_cpu cpu_devices[NR_CPUS];
>+static struct i386_cpu cpu_devices[NR_CPUS];
>
> int arch_register_cpu(int num){
> struct node *parent = NULL;
>
>
>-
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to [email protected]
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
>
>
>