2014-10-08 21:20:35

by Johannes Pointner

Subject: [PATCH v3 2/2] dt: bindings: tps65217: add compatible property for backlight subnode

Add documentation for compatible property of backlight subnode.

Signed-off-by: Johannes Pointner <[email protected]>
---
Changes since v2:
1. Removed the pmic part of the patch.
2. Added newline before subnode in the example.
---
.../devicetree/bindings/video/backlight/tps65217-backlight.txt | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt b/Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt
index 5fb9279..63ef699 100644
--- a/Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt
+++ b/Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt
@@ -6,19 +6,23 @@ used to drive LEDs for use as backlights.
Required properties:
- compatible: "ti,tps65217"
- reg: I2C slave address
-- backlight: node for specifying WLED1 and WLED2 lines in TPS65217
+- backlight: subnode for specifying WLED1 and WLED2 lines in TPS65217
+
+Required subnode properties:
+- compatible: "ti,tps65217-bl"
- isel: selection bit, valid values: 1 for ISEL1 (low-level) and 2 for ISEL2 (high-level)
- fdim: PWM dimming frequency, valid values: 100, 200, 500, 1000
- default-brightness: valid values: 0-100

-Each regulator is defined using the standard binding for regulators.

Example:

tps: tps@24 {
reg = <0x24>;
compatible = "ti,tps65217";
- backlight {
+
+ tps_bl: backlight {
+ compatible = "ti,tps65217-bl";
isel = <1>; /* 1 - ISET1, 2 ISET2 */
fdim = <100>; /* TPS65217_BL_FDIM_100HZ */
default-brightness = <50>;
--
2.1.2

2014-10-30 06:43:41

by Johannes Pointner

Subject: Re: [PATCH v3 2/2] dt: bindings: tps65217: add compatible property for backlight subnode

ping

2014-10-08 23:20 GMT+02:00 Johannes Pointner <[email protected]>:
> Add documentation for compatible property of backlight subnode.
>
> Signed-off-by: Johannes Pointner <[email protected]>
> ---
> Changes since v2:
> 1. Removed the pmic part of the patch.
> 2. Added newline before subnode in the example.
> ---
> .../devicetree/bindings/video/backlight/tps65217-backlight.txt | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt b/Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt
> index 5fb9279..63ef699 100644
> --- a/Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt
> +++ b/Documentation/devicetree/bindings/video/backlight/tps65217-backlight.txt
> @@ -6,19 +6,23 @@ used to drive LEDs for use as backlights.
> Required properties:
> - compatible: "ti,tps65217"
> - reg: I2C slave address
> -- backlight: node for specifying WLED1 and WLED2 lines in TPS65217
> +- backlight: subnode for specifying WLED1 and WLED2 lines in TPS65217
> +
> +Required subnode properties:
> +- compatible: "ti,tps65217-bl"
> - isel: selection bit, valid values: 1 for ISEL1 (low-level) and 2 for ISEL2 (high-level)
> - fdim: PWM dimming frequency, valid values: 100, 200, 500, 1000
> - default-brightness: valid values: 0-100
>
> -Each regulator is defined using the standard binding for regulators.
>
> Example:
>
> tps: tps@24 {
> reg = <0x24>;
> compatible = "ti,tps65217";
> - backlight {
> +
> + tps_bl: backlight {
> + compatible = "ti,tps65217-bl";
> isel = <1>; /* 1 - ISET1, 2 ISET2 */
> fdim = <100>; /* TPS65217_BL_FDIM_100HZ */
> default-brightness = <50>;
> --
> 2.1.2