2023-03-22 14:39:55

by Francesco Dolcini

Subject: [PATCH v2] drm/bridge: lt8912b: return EPROBE_DEFER if bridge is not found

From: Matheus Castello <[email protected]>

Returns EPROBE_DEFER when of_drm_find_bridge() fails, this is consistent
with what all the other DRM bridge drivers are doing and this is
required since the bridge might not be there when the driver is probed
and this should not be a fatal failure.

Cc: <[email protected]>
Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
Signed-off-by: Matheus Castello <[email protected]>
Signed-off-by: Francesco Dolcini <[email protected]>
---
v2: use dev_err_probe() instead of dev_dbg() (Laurent)
---
drivers/gpu/drm/bridge/lontium-lt8912b.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c b/drivers/gpu/drm/bridge/lontium-lt8912b.c
index 2019a8167d69..b40baced1331 100644
--- a/drivers/gpu/drm/bridge/lontium-lt8912b.c
+++ b/drivers/gpu/drm/bridge/lontium-lt8912b.c
@@ -676,8 +676,8 @@ static int lt8912_parse_dt(struct lt8912 *lt)

lt->hdmi_port = of_drm_find_bridge(port_node);
if (!lt->hdmi_port) {
- dev_err(lt->dev, "%s: Failed to get hdmi port\n", __func__);
- ret = -ENODEV;
+ ret = -EPROBE_DEFER;
+ dev_err_probe(lt->dev, ret, "%s: Failed to get hdmi port\n", __func__);
goto err_free_host_node;
}

--
2.25.1

2023-03-22 14:44:35

by Andrzej Hajda

Subject: Re: [PATCH v2] drm/bridge: lt8912b: return EPROBE_DEFER if bridge is not found

On 22.03.2023 15:38, Francesco Dolcini wrote:
> From: Matheus Castello <[email protected]>
>
> Returns EPROBE_DEFER when of_drm_find_bridge() fails, this is consistent
> with what all the other DRM bridge drivers are doing and this is
> required since the bridge might not be there when the driver is probed
> and this should not be a fatal failure.
>
> Cc: <[email protected]>
> Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
> Signed-off-by: Matheus Castello <[email protected]>
> Signed-off-by: Francesco Dolcini <[email protected]>

Reviewed-by: Andrzej Hajda <[email protected]>

Regards
Andrzej

> ---
> v2: use dev_err_probe() instead of dev_dbg() (Laurent)
> ---
> drivers/gpu/drm/bridge/lontium-lt8912b.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c b/drivers/gpu/drm/bridge/lontium-lt8912b.c
> index 2019a8167d69..b40baced1331 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt8912b.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt8912b.c
> @@ -676,8 +676,8 @@ static int lt8912_parse_dt(struct lt8912 *lt)
>
> lt->hdmi_port = of_drm_find_bridge(port_node);
> if (!lt->hdmi_port) {
> - dev_err(lt->dev, "%s: Failed to get hdmi port\n", __func__);
> - ret = -ENODEV;
> + ret = -EPROBE_DEFER;
> + dev_err_probe(lt->dev, ret, "%s: Failed to get hdmi port\n", __func__);
> goto err_free_host_node;
> }
>

2023-03-22 15:40:23

by Laurent Pinchart

Subject: Re: [PATCH v2] drm/bridge: lt8912b: return EPROBE_DEFER if bridge is not found

Hi Francesco,

Thank you for the patch.

On Wed, Mar 22, 2023 at 03:38:21PM +0100, Francesco Dolcini wrote:
> From: Matheus Castello <[email protected]>
>
> Returns EPROBE_DEFER when of_drm_find_bridge() fails, this is consistent
> with what all the other DRM bridge drivers are doing and this is
> required since the bridge might not be there when the driver is probed
> and this should not be a fatal failure.
>
> Cc: <[email protected]>
> Fixes: 30e2ae943c26 ("drm/bridge: Introduce LT8912B DSI to HDMI bridge")
> Signed-off-by: Matheus Castello <[email protected]>
> Signed-off-by: Francesco Dolcini <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> v2: use dev_err_probe() instead of dev_dbg() (Laurent)
> ---
> drivers/gpu/drm/bridge/lontium-lt8912b.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt8912b.c b/drivers/gpu/drm/bridge/lontium-lt8912b.c
> index 2019a8167d69..b40baced1331 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt8912b.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt8912b.c
> @@ -676,8 +676,8 @@ static int lt8912_parse_dt(struct lt8912 *lt)
>
> lt->hdmi_port = of_drm_find_bridge(port_node);
> if (!lt->hdmi_port) {
> - dev_err(lt->dev, "%s: Failed to get hdmi port\n", __func__);
> - ret = -ENODEV;
> + ret = -EPROBE_DEFER;
> + dev_err_probe(lt->dev, ret, "%s: Failed to get hdmi port\n", __func__);
> goto err_free_host_node;
> }
>

--
Regards,

Laurent Pinchart

2023-03-22 17:06:57

by Neil Armstrong

Subject: Re: [PATCH v2] drm/bridge: lt8912b: return EPROBE_DEFER if bridge is not found

Hi,

On Wed, 22 Mar 2023 15:38:21 +0100, Francesco Dolcini wrote:
> Returns EPROBE_DEFER when of_drm_find_bridge() fails, this is consistent
> with what all the other DRM bridge drivers are doing and this is
> required since the bridge might not be there when the driver is probed
> and this should not be a fatal failure.
>
>

Thanks, Applied to https://anongit.freedesktop.org/git/drm/drm-misc.git (drm-misc-fixes)

[1/1] drm/bridge: lt8912b: return EPROBE_DEFER if bridge is not found
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=1a70ca89d59c7c8af006d29b965a95ede0abb0da

--
Neil