2023-06-21 09:53:10

by Yunlei He

[permalink] [raw]
Subject: [f2fs-dev][PATCH 2/2] f2fs: truncate pages if move file range success

If move file range success, it should remove old data from
src and dst page cache.

Signed-off-by: Yunlei He <[email protected]>
---
fs/f2fs/file.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 4adcf62e2665..25ef36f2376a 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -2897,6 +2897,9 @@ static int f2fs_move_file_range(struct file *file_in, loff_t pos_in,
f2fs_mark_inode_dirty_sync(dst, false);
}

+ truncate_pagecache_range(src, pos_in, pos_in + len - 1);
+ truncate_pagecache_range(dst, pos_out, pos_out + len - 1);
+
f2fs_update_time(F2FS_I_SB(src), REQ_TIME);
}

--
2.40.1



2023-06-21 14:06:58

by Chao Yu

[permalink] [raw]
Subject: Re: [f2fs-dev][PATCH 2/2] f2fs: truncate pages if move file range success

On 2023/6/21 17:43, Yunlei He wrote:
> If move file range success, it should remove old data from
> src and dst page cache.
>
> Signed-off-by: Yunlei He <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,