2021-03-31 13:17:10

by Christian König

Subject: Re: [PATCH] drm/ttm: cleanup coding style a bit

Am 31.03.21 um 15:12 schrieb Bernard Zhao:
> Fix sparse warning:
> drivers/gpu/drm/ttm/ttm_bo.c:52:1: warning: symbol 'ttm_global_mutex' was not declared. Should it be static?
> drivers/gpu/drm/ttm/ttm_bo.c:53:10: warning: symbol 'ttm_bo_glob_use_count' was not declared. Should it be static?
>
> Signed-off-by: Bernard Zhao <[email protected]>

You are based on an outdated branch, please rebase on top of drm-misc-next.

Regards,
Christian.

> ---
> drivers/gpu/drm/ttm/ttm_bo.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index 101a68dc615b..eab21643edfb 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -49,8 +49,8 @@ static void ttm_bo_global_kobj_release(struct kobject *kobj);
> /*
> * ttm_global_mutex - protecting the global BO state
> */
> -DEFINE_MUTEX(ttm_global_mutex);
> -unsigned ttm_bo_glob_use_count;
> +static DEFINE_MUTEX(ttm_global_mutex);
> +static unsigned int ttm_bo_glob_use_count;
> struct ttm_bo_global ttm_bo_glob;
> EXPORT_SYMBOL(ttm_bo_glob);
>

2021-04-01 02:07:42

by 赵军奎

Subject: Re:Re: [PATCH] drm/ttm: cleanup coding style a bit

From: "Christian König" <[email protected]>
Date: 2021-03-31 21:15:22
To: Bernard Zhao <[email protected]>,Huang Rui <[email protected]>,David Airlie <[email protected]>,Daniel Vetter <[email protected]>,[email protected],[email protected]
Cc: [email protected]
Subject: Re: [PATCH] drm/ttm: cleanup coding style a bit>Am 31.03.21 um 15:12 schrieb Bernard Zhao:
>> Fix sparse warning:
>> drivers/gpu/drm/ttm/ttm_bo.c:52:1: warning: symbol 'ttm_global_mutex' was not declared. Should it be static?
>> drivers/gpu/drm/ttm/ttm_bo.c:53:10: warning: symbol 'ttm_bo_glob_use_count' was not declared. Should it be static?
>>
>> Signed-off-by: Bernard Zhao <[email protected]>
>
>You are based on an outdated branch, please rebase on top of drm-misc-next.
>

Hi

Sure, thanks for your review！
I will fix this and resubmit this patch.

BR//Bernard

>Regards,
>Christian.
>
>> ---
>> drivers/gpu/drm/ttm/ttm_bo.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
>> index 101a68dc615b..eab21643edfb 100644
>> --- a/drivers/gpu/drm/ttm/ttm_bo.c
>> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
>> @@ -49,8 +49,8 @@ static void ttm_bo_global_kobj_release(struct kobject *kobj);
>> /*
>> * ttm_global_mutex - protecting the global BO state
>> */
>> -DEFINE_MUTEX(ttm_global_mutex);
>> -unsigned ttm_bo_glob_use_count;
>> +static DEFINE_MUTEX(ttm_global_mutex);
>> +static unsigned int ttm_bo_glob_use_count;
>> struct ttm_bo_global ttm_bo_glob;
>> EXPORT_SYMBOL(ttm_bo_glob);
>>
>

2021-04-09 11:09:25

by Christian König

Subject: Re: [PATCH] drm/ttm: cleanup coding style a bit

Am 01.04.21 um 03:59 schrieb Bernard:
>
> From: "Christian König" <[email protected]>
> Date: 2021-03-31 21:15:22
> To: Bernard Zhao <[email protected]>,Huang Rui <[email protected]>,David Airlie <[email protected]>,Daniel Vetter <[email protected]>,[email protected],[email protected]
> Cc: [email protected]
> Subject: Re: [PATCH] drm/ttm: cleanup coding style a bit>Am 31.03.21 um 15:12 schrieb Bernard Zhao:
>>> Fix sparse warning:
>>> drivers/gpu/drm/ttm/ttm_bo.c:52:1: warning: symbol 'ttm_global_mutex' was not declared. Should it be static?
>>> drivers/gpu/drm/ttm/ttm_bo.c:53:10: warning: symbol 'ttm_bo_glob_use_count' was not declared. Should it be static?
>>>
>>> Signed-off-by: Bernard Zhao <[email protected]>
>> You are based on an outdated branch, please rebase on top of drm-misc-next.
>>
> Hi
>
> Sure, thanks for your review！
> I will fix this and resubmit this patch.

Found some time today to do it myself. Please review the patch I've just
send to you.

Thanks,
Christian.

>
> BR//Bernard
>
>> Regards,
>> Christian.
>>
>>> ---
>>> drivers/gpu/drm/ttm/ttm_bo.c | 4 ++--
>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
>>> index 101a68dc615b..eab21643edfb 100644
>>> --- a/drivers/gpu/drm/ttm/ttm_bo.c
>>> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
>>> @@ -49,8 +49,8 @@ static void ttm_bo_global_kobj_release(struct kobject *kobj);
>>> /*
>>> * ttm_global_mutex - protecting the global BO state
>>> */
>>> -DEFINE_MUTEX(ttm_global_mutex);
>>> -unsigned ttm_bo_glob_use_count;
>>> +static DEFINE_MUTEX(ttm_global_mutex);
>>> +static unsigned int ttm_bo_glob_use_count;
>>> struct ttm_bo_global ttm_bo_glob;
>>> EXPORT_SYMBOL(ttm_bo_glob);
>>>
>