2020-01-10 01:40:41

by Yue Haibing

Subject: [PATCH net-next] sfc: remove duplicated include from ef10.c

Remove duplicated include.

Signed-off-by: YueHaibing <[email protected]>
---
drivers/net/ethernet/sfc/ef10.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c
index dc037dd927f8..fa460831af7d 100644
--- a/drivers/net/ethernet/sfc/ef10.c
+++ b/drivers/net/ethernet/sfc/ef10.c
@@ -16,7 +16,6 @@
#include "workarounds.h"
#include "selftest.h"
#include "ef10_sriov.h"
-#include "rx_common.h"
#include <linux/in.h>
#include <linux/jhash.h>
#include <linux/wait.h>

2020-01-10 11:59:18

by Edward Cree

Subject: Re: [PATCH net-next] sfc: remove duplicated include from ef10.c

On 10/01/2020 01:35, YueHaibing wrote:
> Remove duplicated include.
>
> Signed-off-by: YueHaibing <[email protected]>
Acked-by: Edward Cree <[email protected]>
but you seem to have come up with a strange CC list, full of bpf maintainers
 rather than sfc driver maintainers; check your submission scripts?  (AFAIK
 the MAINTAINERS file has the right things in.)

-Ed
> ---
> drivers/net/ethernet/sfc/ef10.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c
> index dc037dd927f8..fa460831af7d 100644
> --- a/drivers/net/ethernet/sfc/ef10.c
> +++ b/drivers/net/ethernet/sfc/ef10.c
> @@ -16,7 +16,6 @@
> #include "workarounds.h"
> #include "selftest.h"
> #include "ef10_sriov.h"
> -#include "rx_common.h"
> #include <linux/in.h>
> #include <linux/jhash.h>
> #include <linux/wait.h>
>
>
>

2020-01-11 01:58:16

by Yue Haibing

Subject: Re: [PATCH net-next] sfc: remove duplicated include from ef10.c

On 2020/1/10 19:57, Edward Cree wrote:
> On 10/01/2020 01:35, YueHaibing wrote:
>> Remove duplicated include.
>>
>> Signed-off-by: YueHaibing <[email protected]>
> Acked-by: Edward Cree <[email protected]>
> but you seem to have come up with a strange CC list, full of bpf maintainers
> rather than sfc driver maintainers; check your submission scripts? (AFAIK
> the MAINTAINERS file has the right things in.)

Thanks, I will check this.
>
> -Ed
>> ---
>> drivers/net/ethernet/sfc/ef10.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c
>> index dc037dd927f8..fa460831af7d 100644
>> --- a/drivers/net/ethernet/sfc/ef10.c
>> +++ b/drivers/net/ethernet/sfc/ef10.c
>> @@ -16,7 +16,6 @@
>> #include "workarounds.h"
>> #include "selftest.h"
>> #include "ef10_sriov.h"
>> -#include "rx_common.h"
>> #include <linux/in.h>
>> #include <linux/jhash.h>
>> #include <linux/wait.h>
>>
>>
>>
>
>
> .
>

2020-01-11 07:12:53

by David Miller

Subject: Re: [PATCH net-next] sfc: remove duplicated include from ef10.c

From: YueHaibing <[email protected]>
Date: Fri, 10 Jan 2020 01:35:17 +0000

> Remove duplicated include.
>
> Signed-off-by: YueHaibing <[email protected]>

Applied, thanks.