Hi Steven,
Here 's a version of my fs/cifs/file.c cleanup patch split into seven
chunks for easier review.
Please use these incremental patches instead of the big one I send you
earlier since I've made a few changes compared to that.
Since you seemed to have trouble with the original patch when included
inline I'll attach the patch files instead, along with a description of
each patch in the email.
For your convenience the patches are also available online at :
http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-whitespace-changes.patch
http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-kfree-changes.patch
http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-cifs_init_private.patch
http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-cifs_open_inode_helper.patch
http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-cifs_convert_flags.patch
http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-cifs_get_disposition.patch
http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-condense_if_else.patch
(listed in the order they apply)
The first patch applies on top of the first whitespace cleanup patch you
already applied to your tree, so you should be able to just apply all 7 in
order to your tree.
I still haven't managed to get hold of/setup a cifs server to test these
against, so they are still only compile tested.
--
Jesper Juhl
Jesper Juhl wrote:
>Here 's a version of my fs/cifs/file.c cleanup patch split into seven
>chunks for easier review.
>Please use these incremental patches instead of the big one I send you
>earlier since I've made a few changes compared to that.
>
>For your convenience the patches are also available online at :
>http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-whitespace-changes.patch
>http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-kfree-changes.patch
>http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-cifs_init_private.patch
>http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-cifs_open_inode_helper.patch
>http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-cifs_convert_flags.patch
>http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-cifs_get_disposition.patch
>http://www.linuxtux.org/~juhl/kernel_patches/fs_cifs_file-cleanups-3-condense_if_else.patch
>(listed in the order they apply)
>
I have reviewed and applied the first two, and also reviewed the
get_disposition patch (which is also fine). I will review the others
this weekend. Good work - thanks.
>I still haven't managed to get hold of/setup a cifs server to test these
>against, so they are still only compile tested.
>
>
I did some testing of this against Samba server last night.