2024-04-02 19:26:00

by Christophe JAILLET

Subject: [PATCH net-next] net: fman: Remove some unused fields in some structure

In "struct muram_info", the 'size' field is unused.
In "struct memac_cfg", the 'fixed_link' field is unused.

Remove them.

Found with cppcheck, unusedStructMember.

Signed-off-by: Christophe JAILLET <[email protected]>
---
Compile tested only.

For fman_memac.c, I think that it is a left-over from commit 5d93cfcf7360
("net: dpaa: Convert to phylink").
Maybe, #include <linux/phy_fixed.h> can be removed too, but it is not the
purpose of this patch.
---
drivers/net/ethernet/freescale/fman/fman_memac.c | 1 -
drivers/net/ethernet/freescale/fman/fman_muram.c | 1 -
2 files changed, 2 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fman/fman_memac.c b/drivers/net/ethernet/freescale/fman/fman_memac.c
index 758535adc9ff..92b8f4ab26f1 100644
--- a/drivers/net/ethernet/freescale/fman/fman_memac.c
+++ b/drivers/net/ethernet/freescale/fman/fman_memac.c
@@ -267,7 +267,6 @@ struct memac_cfg {
bool reset_on_init;
bool pause_ignore;
bool promiscuous_mode_enable;
- struct fixed_phy_status *fixed_link;
u16 max_frame_length;
u16 pause_quanta;
u32 tx_ipg_length;
diff --git a/drivers/net/ethernet/freescale/fman/fman_muram.c b/drivers/net/ethernet/freescale/fman/fman_muram.c
index f557d68e5b76..1ed245a2ee01 100644
--- a/drivers/net/ethernet/freescale/fman/fman_muram.c
+++ b/drivers/net/ethernet/freescale/fman/fman_muram.c
@@ -12,7 +12,6 @@
struct muram_info {
struct gen_pool *pool;
void __iomem *vbase;
- size_t size;
phys_addr_t pbase;
};

--
2.44.0

2024-04-03 15:28:45

by Simon Horman

Subject: Re: [PATCH net-next] net: fman: Remove some unused fields in some structure

On Tue, Apr 02, 2024 at 08:55:50PM +0200, Christophe JAILLET wrote:
> In "struct muram_info", the 'size' field is unused.
> In "struct memac_cfg", the 'fixed_link' field is unused.
>
> Remove them.
>
> Found with cppcheck, unusedStructMember.
>
> Signed-off-by: Christophe JAILLET <[email protected]>

Reviewed-by: Simon Horman <[email protected]>

2024-04-04 02:51:12

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next] net: fman: Remove some unused fields in some structure

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Tue, 2 Apr 2024 20:55:50 +0200 you wrote:
> In "struct muram_info", the 'size' field is unused.
> In "struct memac_cfg", the 'fixed_link' field is unused.
>
> Remove them.
>
> Found with cppcheck, unusedStructMember.
>
> [...]

Here is the summary with links:
- [net-next] net: fman: Remove some unused fields in some structure
https://git.kernel.org/netdev/net-next/c/04af1d643701

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html