2020-12-28 03:20:25

by Zefan Li

[permalink] [raw]
Subject: [PATCH] cpuset: Remove stale URLs in the MAINTAINERS entry

Those URLs are no longer accessable.

Reported-by: Steve Wahl <[email protected]>
Signed-off-by: Zefan Li <[email protected]>
---
MAINTAINERS | 2 --
1 file changed, 2 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index ae9b1dd748c4..2fe8eb54639e 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -4477,8 +4477,6 @@ CONTROL GROUP - CPUSET
M: Li Zefan <[email protected]>
L: [email protected]
S: Maintained
-W: http://www.bullopensource.org/cpuset/
-W: http://oss.sgi.com/projects/cpusets/
T: git git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git
F: Documentation/admin-guide/cgroup-v1/cpusets.rst
F: include/linux/cpuset.h
--
2.22.0


2020-12-28 06:04:54

by Joe Perches

[permalink] [raw]
Subject: Re: [PATCH] cpuset: Remove stale URLs in the MAINTAINERS entry

On Mon, 2020-12-28 at 11:17 +0800, Zefan Li wrote:
> Those URLs are no longer accessable.
>
> Reported-by: Steve Wahl <[email protected]>
> Signed-off-by: Zefan Li <[email protected]>
> ---
> ?MAINTAINERS | 2 --
> ?1 file changed, 2 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ae9b1dd748c4..2fe8eb54639e 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -4477,8 +4477,6 @@ CONTROL GROUP - CPUSET
> ?M: Li Zefan <[email protected]>
> ?L: [email protected]
> ?S: Maintained
> -W: http://www.bullopensource.org/cpuset/
> -W: http://oss.sgi.com/projects/cpusets/

The general argument to avoid removal of these no longer valid links
is that they may still be available from archive.org.

For instance:

https://web.archive.org/web/20170512010721/http://oss.sgi.com/projects/cpusets/

It may be appropriate to copy the content into a local Documentation
file somewhere to avoid the need to lookup old reference links.


2020-12-28 06:33:38

by Zefan Li

[permalink] [raw]
Subject: Re: [PATCH] cpuset: Remove stale URLs in the MAINTAINERS entry

On 2020/12/28 14:01, Joe Perches wrote:
> On Mon, 2020-12-28 at 11:17 +0800, Zefan Li wrote:
>> Those URLs are no longer accessable.
>>
>> Reported-by: Steve Wahl <[email protected]>
>> Signed-off-by: Zefan Li <[email protected]>
>> ---
>>  MAINTAINERS | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index ae9b1dd748c4..2fe8eb54639e 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -4477,8 +4477,6 @@ CONTROL GROUP - CPUSET
>>  M: Li Zefan <[email protected]>
>>  L: [email protected]
>>  S: Maintained
>> -W: http://www.bullopensource.org/cpuset/
>> -W: http://oss.sgi.com/projects/cpusets/
>
> The general argument to avoid removal of these no longer valid links
> is that they may still be available from archive.org.
>
> For instance:
>
> https://web.archive.org/web/20170512010721/http://oss.sgi.com/projects/cpusets/
>
> It may be appropriate to copy the content into a local Documentation
> file somewhere to avoid the need to lookup old reference links.
>

I don't think the contents in those links provide valuable information about cpusets.
We have documents in Documentation/admin-guide/cgroup/ and man cpuset(7). So I think
we can just remove them.

2021-01-04 15:30:45

by Steve Wahl

[permalink] [raw]
Subject: Re: [PATCH] cpuset: Remove stale URLs in the MAINTAINERS entry

On Mon, Dec 28, 2020 at 02:31:52PM +0800, Zefan Li wrote:
> On 2020/12/28 14:01, Joe Perches wrote:
> > On Mon, 2020-12-28 at 11:17 +0800, Zefan Li wrote:
> >> Those URLs are no longer accessable.
> >
> > The general argument to avoid removal of these no longer valid links
> > is that they may still be available from archive.org.
> >
> > ...
> >
> > It may be appropriate to copy the content into a local Documentation
> > file somewhere to avoid the need to lookup old reference links.
> >
>
> I don't think the contents in those links provide valuable information about cpusets.
> We have documents in Documentation/admin-guide/cgroup/ and man cpuset(7). So I think
> we can just remove them.

I agree, I did the archive.org lookup and it appeared that the current
version of most of this information is already under the Documentation
tree.

--> Steve

--
Steve Wahl, Hewlett Packard Enterprise