2005-04-22 04:09:53

by Richard Drummond

[permalink] [raw]
Subject: [PATCH] Clean-up and bug fix for tdfxfb framebuffer size detection

Attached is a patch against 2.6.11.7 which tidies up the tdfxfb framebuffer
size detection code a little and fixes the broken support for Voodoo4/5 cards.
(I haven't tested this on a Voodoo5, however, because I don't have the
hardware).

Signed-off-by: Richard Drummond <[email protected]>


Attachments:
(No filename) (299.00 B)
tdfxfb_mem_fix.diff (2.41 kB)
Download all attachments

2005-04-22 08:48:40

by Chris Ross

[permalink] [raw]
Subject: Re: [PATCH] Clean-up and bug fix for tdfxfb framebuffer size detection

Hi Richard,

Richard Drummond escreveu:
> Attached is a patch against 2.6.11.7 which tidies up the tdfxfb framebuffer
> size detection code a little and fixes the broken support for Voodoo4/5 cards.
> (I haven't tested this on a Voodoo5, however, because I don't have the
> hardware).

I /do/ have the hardware, so I am very glad to see someone working on
support for the Voodoo 5. Are there any specific tests you would like me
to perform and send you the results from?

Regards,
Chris R.

2005-04-22 18:17:40

by Richard Drummond

[permalink] [raw]
Subject: Re: [PATCH] Clean-up and bug fix for tdfxfb framebuffer size detection

Hi Chris

On Friday 22 April 2005 03:48 am, Chris Ross wrote:
> I /do/ have the hardware, so I am very glad to see someone working on
> support for the Voodoo 5.

I am glad somebody is interested. ;-)

> Are there any specific tests you would like me
> to perform and send you the results from?

It's quite simple really. With this patch, does tdfxfb report the right amount
of framebuffer memory for your card? The method it used to determine the
amount of memory for the Voodoo4/5 before was wrong. If it gave the right
value before, then it was probably just a coincidence.

Cheers,
Rich