2005-05-11 17:24:12

by Corey Minyard

[permalink] [raw]
Subject: acpi=off and acpi_get_firmware_table

In 2.6.12-rc4, I added acpi=off to the kernel command line and it
panic-ed in acpi_get_firmware_table, called from the IPMI driver.

The attached patch fixes the problem, but it still spits out ugly
"ACPI-0166: *** Error: Invalid address flags 8" errors. So I doubt the
patch is right, but maybe it points to something else.

Is it legal to call acpi_get_firmware_table if acpi is off? If not, how
can I tell that acpi is off?

-Corey

Attachments:
acpi_table_null_fix.patch (528.00 B)

2005-05-12 02:48:56

by Shaohua Li

[permalink] [raw]
Subject: Re: acpi=off and acpi_get_firmware_table

On Wed, 2005-05-11 at 12:21 -0500, Corey Minyard wrote:
> In 2.6.12-rc4, I added acpi=off to the kernel command line and it
> panic-ed in acpi_get_firmware_table, called from the IPMI driver.
>
> The attached patch fixes the problem, but it still spits out ugly
> "ACPI-0166: *** Error: Invalid address flags 8" errors. So I doubt the
> patch is right, but maybe it points to something else.
>
> Is it legal to call acpi_get_firmware_table if acpi is off? If not, how
> can I tell that acpi is off?
Please check 'acpi_disabled' variable.

Thanks,
Shaohua

2005-05-12 02:59:18

by Corey Minyard

[permalink] [raw]
Subject: Re: acpi=off and acpi_get_firmware_table

Shaohua Li wrote:

>On Wed, 2005-05-11 at 12:21 -0500, Corey Minyard wrote:
>
>
>>In 2.6.12-rc4, I added acpi=off to the kernel command line and it
>>panic-ed in acpi_get_firmware_table, called from the IPMI driver.
>>
>>The attached patch fixes the problem, but it still spits out ugly
>>"ACPI-0166: *** Error: Invalid address flags 8" errors. So I doubt the
>>patch is right, but maybe it points to something else.
>>
>>Is it legal to call acpi_get_firmware_table if acpi is off? If not, how
>>can I tell that acpi is off?
>>
>>
>Please check 'acpi_disabled' variable.
>
>
acpi_disabled is not available on ia64. It doesn't seem to be a
standard interface. So that's not an option.

-Corey

2005-05-12 03:02:15

by Shaohua Li

[permalink] [raw]
Subject: Re: acpi=off and acpi_get_firmware_table

On Wed, 2005-05-11 at 21:59 -0500, Corey Minyard wrote:
> Shaohua Li wrote:
>
> >On Wed, 2005-05-11 at 12:21 -0500, Corey Minyard wrote:
> >
> >
> >>In 2.6.12-rc4, I added acpi=off to the kernel command line and it
> >>panic-ed in acpi_get_firmware_table, called from the IPMI driver.
> >>
> >>The attached patch fixes the problem, but it still spits out ugly
> >>"ACPI-0166: *** Error: Invalid address flags 8" errors. So I doubt the
> >>patch is right, but maybe it points to something else.
> >>
> >>Is it legal to call acpi_get_firmware_table if acpi is off? If not, how
> >>can I tell that acpi is off?
> >>
> >>
> >Please check 'acpi_disabled' variable.
> >
> >
> acpi_disabled is not available on ia64. It doesn't seem to be a
> standard interface. So that's not an option.
It always return 0 in IA64. IA64 can't disable ACPI.

Thanks,
Shaohua