2018-09-19 14:54:32

by zhong jiang

Subject: [PATCH] ieee802154: remove a redundant local variable 'i'

The local variable 'i' is never used after being assigned.
hence it should be redundant adn can be removed.

Signed-off-by: zhong jiang <[email protected]>
---
net/ieee802154/nl802154.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c
index 99f6c25..5b90151 100644
--- a/net/ieee802154/nl802154.c
+++ b/net/ieee802154/nl802154.c
@@ -445,7 +445,6 @@ static int nl802154_send_wpan_phy(struct cfg802154_registered_device *rdev,
{
struct nlattr *nl_cmds;
void *hdr;
- int i;

hdr = nl802154hdr_put(msg, portid, seq, flags, cmd);
if (!hdr)
@@ -508,7 +507,6 @@ static int nl802154_send_wpan_phy(struct cfg802154_registered_device *rdev,
if (!nl_cmds)
goto nla_put_failure;

- i = 0;
#define CMD(op, n) \
do { \
if (rdev->ops->op) { \
--
1.7.12.4

2018-09-27 14:48:10

by Stefan Schmidt

Subject: Re: [PATCH] ieee802154: remove a redundant local variable 'i'

Hello.

On 19/09/2018 16:41, zhong jiang wrote:
> The local variable 'i' is never used after being assigned.
> hence it should be redundant adn can be removed.
>
> Signed-off-by: zhong jiang <[email protected]>
> ---
> net/ieee802154/nl802154.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c
> index 99f6c25..5b90151 100644
> --- a/net/ieee802154/nl802154.c
> +++ b/net/ieee802154/nl802154.c
> @@ -445,7 +445,6 @@ static int nl802154_send_wpan_phy(struct cfg802154_registered_device *rdev,
> {
> struct nlattr *nl_cmds;
> void *hdr;
> - int i;
>
> hdr = nl802154hdr_put(msg, portid, seq, flags, cmd);
> if (!hdr)
> @@ -508,7 +507,6 @@ static int nl802154_send_wpan_phy(struct cfg802154_registered_device *rdev,
> if (!nl_cmds)
> goto nla_put_failure;
>
> - i = 0;
> #define CMD(op, n) \
> do { \
> if (rdev->ops->op) { \
>

Sorry, but this patch is wrong. The variable i is used in line 513
inside the CMD() macro. The compiler clearly tells this when running
with your patch:

net/ieee802154/nl802154.c: In function ‘nl802154_send_wpan_phy’:
net/ieee802154/nl802154.c:513:4: error: ‘i’ undeclared (first use in
this function)

I would appreciate if patches sent out would at least be compile tested.

regards
Stefan Schmidt

2018-09-28 06:38:37

by zhong jiang

Subject: Re: [PATCH] ieee802154: remove a redundant local variable 'i'

On 2018/9/27 22:47, Stefan Schmidt wrote:
> Hello.
>
> On 19/09/2018 16:41, zhong jiang wrote:
>> The local variable 'i' is never used after being assigned.
>> hence it should be redundant adn can be removed.
>>
>> Signed-off-by: zhong jiang <[email protected]>
>> ---
>> net/ieee802154/nl802154.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c
>> index 99f6c25..5b90151 100644
>> --- a/net/ieee802154/nl802154.c
>> +++ b/net/ieee802154/nl802154.c
>> @@ -445,7 +445,6 @@ static int nl802154_send_wpan_phy(struct cfg802154_registered_device *rdev,
>> {
>> struct nlattr *nl_cmds;
>> void *hdr;
>> - int i;
>>
>> hdr = nl802154hdr_put(msg, portid, seq, flags, cmd);
>> if (!hdr)
>> @@ -508,7 +507,6 @@ static int nl802154_send_wpan_phy(struct cfg802154_registered_device *rdev,
>> if (!nl_cmds)
>> goto nla_put_failure;
>>
>> - i = 0;
>> #define CMD(op, n) \
>> do { \
>> if (rdev->ops->op) { \
>>
> Sorry, but this patch is wrong. The variable i is used in line 513
> inside the CMD() macro. The compiler clearly tells this when running
> with your patch:
>
> net/ieee802154/nl802154.c: In function ‘nl802154_send_wpan_phy’:
> net/ieee802154/nl802154.c:513:4: error: ‘i’ undeclared (first use in
> this function)
>
> I would appreciate if patches sent out would at least be compile tested.
Sorry, I really double check and compile test.

Thanks,
zhong jiang
> regards
> Stefan Schmidt
>
> .
>