2017-06-12 06:33:08

by Arvind Yadav

Subject: [PATCH] watchdog: zx2967: constify zx2967_wdt_ops.

File size before:
text data bss dec hex filename
988 288 0 1276 4fc drivers/watchdog/zx2967_wdt.o

File size After adding 'const':
text data bss dec hex filename
1084 192 0 1276 4fc drivers/watchdog/zx2967_wdt.o

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/watchdog/zx2967_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/zx2967_wdt.c b/drivers/watchdog/zx2967_wdt.c
index e290d5a..17774de 100644
--- a/drivers/watchdog/zx2967_wdt.c
+++ b/drivers/watchdog/zx2967_wdt.c
@@ -154,7 +154,7 @@ static int zx2967_wdt_keepalive(struct watchdog_device *wdd)
.identity = "zx2967 watchdog",
};

-static struct watchdog_ops zx2967_wdt_ops = {
+static const struct watchdog_ops zx2967_wdt_ops = {
.owner = THIS_MODULE,
.start = zx2967_wdt_start,
.stop = zx2967_wdt_stop,
--
1.9.1

2017-06-15 17:26:33

by Guenter Roeck

Subject: Re: [PATCH] watchdog: zx2967: constify zx2967_wdt_ops.

On Mon, Jun 12, 2017 at 12:02:39PM +0530, Arvind Yadav wrote:
> File size before:
> text data bss dec hex filename
> 988 288 0 1276 4fc drivers/watchdog/zx2967_wdt.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 1084 192 0 1276 4fc drivers/watchdog/zx2967_wdt.o
>
> Signed-off-by: Arvind Yadav <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

> ---
> drivers/watchdog/zx2967_wdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/zx2967_wdt.c b/drivers/watchdog/zx2967_wdt.c
> index e290d5a..17774de 100644
> --- a/drivers/watchdog/zx2967_wdt.c
> +++ b/drivers/watchdog/zx2967_wdt.c
> @@ -154,7 +154,7 @@ static int zx2967_wdt_keepalive(struct watchdog_device *wdd)
> .identity = "zx2967 watchdog",
> };
>
> -static struct watchdog_ops zx2967_wdt_ops = {
> +static const struct watchdog_ops zx2967_wdt_ops = {
> .owner = THIS_MODULE,
> .start = zx2967_wdt_start,
> .stop = zx2967_wdt_stop,
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html