2018-10-15 07:39:34

by Christophe Leroy

Subject: [PATCH] powerpc/traps: remove redundant in_interrupt panic in die()

do_exit() already includes a test to panic() is in_interrupt()

This patch removes powerpc one which is redundant.

Signed-off-by: Christophe Leroy <[email protected]>
---
arch/powerpc/kernel/traps.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c
index 39fde4b40b6e..47904cd1ff46 100644
--- a/arch/powerpc/kernel/traps.c
+++ b/arch/powerpc/kernel/traps.c
@@ -247,8 +247,6 @@ static void oops_end(unsigned long flags, struct pt_regs *regs,
mdelay(MSEC_PER_SEC);
}

- if (in_interrupt())
- panic("Fatal exception in interrupt");
if (panic_on_oops)
panic("Fatal exception");
do_exit(signr);
--
2.13.3

2018-10-19 02:53:18

by Michael Ellerman

Subject: Re: powerpc/traps: remove redundant in_interrupt panic in die()

On Mon, 2018-10-15 at 07:38:10 UTC, Christophe Leroy wrote:
> do_exit() already includes a test to panic() is in_interrupt()
>
> This patch removes powerpc one which is redundant.
>
> Signed-off-by: Christophe Leroy <[email protected]>

Applied to powerpc next, thanks.

https://git.kernel.org/powerpc/c/bd03fd84a53ac9ddaeb0a0fc4c4c98

cheers