2019-03-17 23:10:17

by Colin King

Subject: [PATCH] hostfs: fix mismatch between link_file definition and declaration

From: Colin Ian King <[email protected]>

The function link_file declaration in the header file has the order
of the two arguments (from, to) swapped when compared to the definition
arguments of (to, from). Fix this by swapping them around to match
the definition.

This error predates the git history, so no idea when this error
was introduced.

Signed-off-by: Colin Ian King <[email protected]>
---
fs/hostfs/hostfs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/hostfs/hostfs.h b/fs/hostfs/hostfs.h
index 33b8423ef0c9..f4295aa19350 100644
--- a/fs/hostfs/hostfs.h
+++ b/fs/hostfs/hostfs.h
@@ -87,7 +87,7 @@ extern int do_mkdir(const char *file, int mode);
extern int hostfs_do_rmdir(const char *file);
extern int do_mknod(const char *file, int mode, unsigned int major,
unsigned int minor);
-extern int link_file(const char *from, const char *to);
+extern int link_file(const char *to, const char *from);
extern int hostfs_do_readlink(char *file, char *buf, int size);
extern int rename_file(char *from, char *to);
extern int rename2_file(char *from, char *to, unsigned int flags);
--
2.20.1

2019-03-17 23:51:21

by Richard Weinberger

Subject: Re: [PATCH] hostfs: fix mismatch between link_file definition and declaration

Am Montag, 18. M?rz 2019, 00:09:09 CET schrieb Colin King:
> From: Colin Ian King <[email protected]>
>
> The function link_file declaration in the header file has the order
> of the two arguments (from, to) swapped when compared to the definition
> arguments of (to, from). Fix this by swapping them around to match
> the definition.
>
> This error predates the git history, so no idea when this error
> was introduced.

commit bf4f804738544a95b8bc8d6a7e2629c3fc0240dd
Author: jdike <jdike>
Date: Sat Dec 9 22:52:44 2000 +0000

hostfs now mostly works. Almost all of the common operations are now
implemented, the main exceptions being mknod and executing files from
a hostfs filesystem.

Enough archaeology for today. :-)

Thanks,
//richard

2019-03-18 08:43:02

by Colin King

Subject: Re: [PATCH] hostfs: fix mismatch between link_file definition and declaration

On 17/03/2019 23:49, Richard Weinberger wrote:
> Am Montag, 18. März 2019, 00:09:09 CET schrieb Colin King:
>> From: Colin Ian King <[email protected]>
>>
>> The function link_file declaration in the header file has the order
>> of the two arguments (from, to) swapped when compared to the definition
>> arguments of (to, from). Fix this by swapping them around to match
>> the definition.
>>
>> This error predates the git history, so no idea when this error
>> was introduced.
>
> commit bf4f804738544a95b8bc8d6a7e2629c3fc0240dd
> Author: jdike <jdike>
> Date: Sat Dec 9 22:52:44 2000 +0000
>
> hostfs now mostly works. Almost all of the common operations are now
> implemented, the main exceptions being mknod and executing files from
> a hostfs filesystem.
>
> Enough archaeology for today. :-)

Nice. How do you find these ancient git commits?

>
> Thanks,
> //richard
>
>

2019-03-18 08:48:58

by walter harms

Subject: Re: [PATCH] hostfs: fix mismatch between link_file definition and declaration

Hi,
Colin is obvously right with that.
But my guess is that the error occured because the
pattern (from, to) is brocken here. Also

Maybe the maintainer can fix that.

just my 2 cents,

re,
wh


Am 18.03.2019 00:09, schrieb Colin King:
> From: Colin Ian King <[email protected]>
>
> The function link_file declaration in the header file has the order
> of the two arguments (from, to) swapped when compared to the definition
> arguments of (to, from). Fix this by swapping them around to match
> the definition.
>
> This error predates the git history, so no idea when this error
> was introduced.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> fs/hostfs/hostfs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/hostfs/hostfs.h b/fs/hostfs/hostfs.h
> index 33b8423ef0c9..f4295aa19350 100644
> --- a/fs/hostfs/hostfs.h
> +++ b/fs/hostfs/hostfs.h
> @@ -87,7 +87,7 @@ extern int do_mkdir(const char *file, int mode);
> extern int hostfs_do_rmdir(const char *file);
> extern int do_mknod(const char *file, int mode, unsigned int major,
> unsigned int minor);
> -extern int link_file(const char *from, const char *to);
> +extern int link_file(const char *to, const char *from);
> extern int hostfs_do_readlink(char *file, char *buf, int size);
> extern int rename_file(char *from, char *to);
> extern int rename2_file(char *from, char *to, unsigned int flags);

2019-03-18 09:47:32

by Richard Weinberger

Subject: Re: [PATCH] hostfs: fix mismatch between link_file definition and declaration

Am Montag, 18. M?rz 2019, 09:41:28 CET schrieb Colin Ian King:
> On 17/03/2019 23:49, Richard Weinberger wrote:
> > Am Montag, 18. M?rz 2019, 00:09:09 CET schrieb Colin King:
> >> From: Colin Ian King <[email protected]>
> >>
> >> The function link_file declaration in the header file has the order
> >> of the two arguments (from, to) swapped when compared to the definition
> >> arguments of (to, from). Fix this by swapping them around to match
> >> the definition.
> >>
> >> This error predates the git history, so no idea when this error
> >> was introduced.
> >
> > commit bf4f804738544a95b8bc8d6a7e2629c3fc0240dd
> > Author: jdike <jdike>
> > Date: Sat Dec 9 22:52:44 2000 +0000
> >
> > hostfs now mostly works. Almost all of the common operations are now
> > implemented, the main exceptions being mknod and executing files from
> > a hostfs filesystem.
> >
> > Enough archaeology for today. :-)
>
> Nice. How do you find these ancient git commits?

This commit is from the old UML cvs tree.
I did a import to git some time ago and pushed it to:
https://git.kernel.org/pub/scm/linux/kernel/git/rw/uml-history.git/

For classic pre-git stuff, check:
https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/

Thanks,
//richard