2020-12-15 14:59:24

by Tom Rix

Subject: [PATCH] greybus: remove h from printk format specifier

From: Tom Rix <[email protected]>

See Documentation/core-api/printk-formats.rst.
h should no longer be used in the format specifier for printk.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/greybus/greybus_trace.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/greybus/greybus_trace.h b/drivers/greybus/greybus_trace.h
index 1bc9f1275c65..616a3bd61aa6 100644
--- a/drivers/greybus/greybus_trace.h
+++ b/drivers/greybus/greybus_trace.h
@@ -40,7 +40,7 @@ DECLARE_EVENT_CLASS(gb_message,
__entry->result = message->header->result;
),

- TP_printk("size=%hu operation_id=0x%04x type=0x%02x result=0x%02x",
+ TP_printk("size=%u operation_id=0x%04x type=0x%02x result=0x%02x",
__entry->size, __entry->operation_id,
__entry->type, __entry->result)
);
@@ -317,7 +317,7 @@ DECLARE_EVENT_CLASS(gb_interface,
__entry->mode_switch = intf->mode_switch;
),

- TP_printk("intf_id=%hhu device_id=%hhu module_id=%hhu D=%d J=%d A=%d E=%d M=%d",
+ TP_printk("intf_id=%u device_id=%u module_id=%u D=%d J=%d A=%d E=%d M=%d",
__entry->id, __entry->device_id, __entry->module_id,
__entry->disconnected, __entry->ejected, __entry->active,
__entry->enabled, __entry->mode_switch)
@@ -391,7 +391,7 @@ DECLARE_EVENT_CLASS(gb_module,
__entry->disconnected = module->disconnected;
),

- TP_printk("hd_bus_id=%d module_id=%hhu num_interfaces=%zu disconnected=%d",
+ TP_printk("hd_bus_id=%d module_id=%u num_interfaces=%zu disconnected=%d",
__entry->hd_bus_id, __entry->module_id,
__entry->num_interfaces, __entry->disconnected)
);
--
2.27.0

2020-12-15 15:40:01

by Alex Elder

Subject: Re: [PATCH] greybus: remove h from printk format specifier

On 12/15/20 8:53 AM, [email protected] wrote:
> From: Tom Rix <[email protected]>
>
> See Documentation/core-api/printk-formats.rst.
> h should no longer be used in the format specifier for printk.
>
> Signed-off-by: Tom Rix <[email protected]>

Looks good.

Reviewed-by: Alex Elder <[email protected]>

> ---
> drivers/greybus/greybus_trace.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/greybus/greybus_trace.h b/drivers/greybus/greybus_trace.h
> index 1bc9f1275c65..616a3bd61aa6 100644
> --- a/drivers/greybus/greybus_trace.h
> +++ b/drivers/greybus/greybus_trace.h
> @@ -40,7 +40,7 @@ DECLARE_EVENT_CLASS(gb_message,
> __entry->result = message->header->result;
> ),
>
> - TP_printk("size=%hu operation_id=0x%04x type=0x%02x result=0x%02x",
> + TP_printk("size=%u operation_id=0x%04x type=0x%02x result=0x%02x",
> __entry->size, __entry->operation_id,
> __entry->type, __entry->result)
> );
> @@ -317,7 +317,7 @@ DECLARE_EVENT_CLASS(gb_interface,
> __entry->mode_switch = intf->mode_switch;
> ),
>
> - TP_printk("intf_id=%hhu device_id=%hhu module_id=%hhu D=%d J=%d A=%d E=%d M=%d",
> + TP_printk("intf_id=%u device_id=%u module_id=%u D=%d J=%d A=%d E=%d M=%d",
> __entry->id, __entry->device_id, __entry->module_id,
> __entry->disconnected, __entry->ejected, __entry->active,
> __entry->enabled, __entry->mode_switch)
> @@ -391,7 +391,7 @@ DECLARE_EVENT_CLASS(gb_module,
> __entry->disconnected = module->disconnected;
> ),
>
> - TP_printk("hd_bus_id=%d module_id=%hhu num_interfaces=%zu disconnected=%d",
> + TP_printk("hd_bus_id=%d module_id=%u num_interfaces=%zu disconnected=%d",
> __entry->hd_bus_id, __entry->module_id,
> __entry->num_interfaces, __entry->disconnected)
> );
>