2021-11-15 01:21:08

by Randy Dunlap

Subject: [PATCH] mips: lantiq: add support for clk_get_parent()

Provide a simple implementation of clk_get_parent() in the
lantiq subarch so that callers of it will build without errors.

Fixes this build error:
ERROR: modpost: "clk_get_parent" [drivers/iio/adc/ingenic-adc.ko] undefined!

Fixes: 171bb2f19ed6 ("MIPS: Lantiq: Add initial support for Lantiq SoCs")
Signed-off-by: Randy Dunlap <[email protected]>
Suggested-by: Russell King (Oracle) <[email protected]>
Cc: [email protected]
Cc: John Crispin <[email protected]>
Cc: Thomas Bogendoerfer <[email protected]>
Cc: Jonathan Cameron <[email protected]>
Cc: [email protected]
Cc: Russell King <[email protected]>
Cc: Andy Shevchenko <[email protected]>
---
arch/mips/lantiq/clk.c | 6 ++++++
1 file changed, 6 insertions(+)

--- linux-next-20211112.orig/arch/mips/lantiq/clk.c
+++ linux-next-20211112/arch/mips/lantiq/clk.c
@@ -158,6 +158,12 @@ void clk_deactivate(struct clk *clk)
}
EXPORT_SYMBOL(clk_deactivate);

+struct clk *clk_get_parent(struct clk *clk)
+{
+ return NULL;
+}
+EXPORT_SYMBOL(clk_get_parent);
+
static inline u32 get_counter_resolution(void)
{
u32 res;

2021-11-15 19:40:24

by Jonathan Cameron

Subject: Re: [PATCH] mips: lantiq: add support for clk_get_parent()

On Sun, 14 Nov 2021 17:20:51 -0800
Randy Dunlap <[email protected]> wrote:

> Provide a simple implementation of clk_get_parent() in the
> lantiq subarch so that callers of it will build without errors.
>
> Fixes this build error:
> ERROR: modpost: "clk_get_parent" [drivers/iio/adc/ingenic-adc.ko] undefined!
>
> Fixes: 171bb2f19ed6 ("MIPS: Lantiq: Add initial support for Lantiq SoCs")
> Signed-off-by: Randy Dunlap <[email protected]>
> Suggested-by: Russell King (Oracle) <[email protected]>
> Cc: [email protected]
> Cc: John Crispin <[email protected]>
> Cc: Thomas Bogendoerfer <[email protected]>
> Cc: Jonathan Cameron <[email protected]>
> Cc: [email protected]
> Cc: Russell King <[email protected]>
> Cc: Andy Shevchenko <[email protected]>

Acked-by: Jonathan Cameron <[email protected]>

Thanks for tidying this up.

Jonathan

> ---
> arch/mips/lantiq/clk.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> --- linux-next-20211112.orig/arch/mips/lantiq/clk.c
> +++ linux-next-20211112/arch/mips/lantiq/clk.c
> @@ -158,6 +158,12 @@ void clk_deactivate(struct clk *clk)
> }
> EXPORT_SYMBOL(clk_deactivate);
>
> +struct clk *clk_get_parent(struct clk *clk)
> +{
> + return NULL;
> +}
> +EXPORT_SYMBOL(clk_get_parent);
> +
> static inline u32 get_counter_resolution(void)
> {
> u32 res;

2021-11-16 01:25:04

by John Crispin

Subject: Re: [PATCH] mips: lantiq: add support for clk_get_parent()

On 15.11.21 02:20, Randy Dunlap wrote:
> Provide a simple implementation of clk_get_parent() in the
> lantiq subarch so that callers of it will build without errors.
>
> Fixes this build error:
> ERROR: modpost: "clk_get_parent" [drivers/iio/adc/ingenic-adc.ko] undefined!
>
> Fixes: 171bb2f19ed6 ("MIPS: Lantiq: Add initial support for Lantiq SoCs")
> Signed-off-by: Randy Dunlap <[email protected]>
> Suggested-by: Russell King (Oracle) <[email protected]>
> Cc: [email protected]
> Cc: John Crispin <[email protected]>
> Cc: Thomas Bogendoerfer <[email protected]>
> Cc: Jonathan Cameron <[email protected]>
> Cc: [email protected]
> Cc: Russell King <[email protected]>
> Cc: Andy Shevchenko <[email protected]>

Acked-by: John Crispin <[email protected]>

// we added the same fix for mips/ralink a while back

> ---
> arch/mips/lantiq/clk.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> --- linux-next-20211112.orig/arch/mips/lantiq/clk.c
> +++ linux-next-20211112/arch/mips/lantiq/clk.c
> @@ -158,6 +158,12 @@ void clk_deactivate(struct clk *clk)
> }
> EXPORT_SYMBOL(clk_deactivate);
>
> +struct clk *clk_get_parent(struct clk *clk)
> +{
> + return NULL;
> +}
> +EXPORT_SYMBOL(clk_get_parent);
> +
> static inline u32 get_counter_resolution(void)
> {
> u32 res;
>

2021-11-16 08:55:09

by Thomas Bogendoerfer

Subject: Re: [PATCH] mips: lantiq: add support for clk_get_parent()

On Sun, Nov 14, 2021 at 05:20:51PM -0800, Randy Dunlap wrote:
> Provide a simple implementation of clk_get_parent() in the
> lantiq subarch so that callers of it will build without errors.
>
> Fixes this build error:
> ERROR: modpost: "clk_get_parent" [drivers/iio/adc/ingenic-adc.ko] undefined!
>
> Fixes: 171bb2f19ed6 ("MIPS: Lantiq: Add initial support for Lantiq SoCs")
> Signed-off-by: Randy Dunlap <[email protected]>
> Suggested-by: Russell King (Oracle) <[email protected]>
> Cc: [email protected]
> Cc: John Crispin <[email protected]>
> Cc: Thomas Bogendoerfer <[email protected]>
> Cc: Jonathan Cameron <[email protected]>
> Cc: [email protected]
> Cc: Russell King <[email protected]>
> Cc: Andy Shevchenko <[email protected]>
> ---
> arch/mips/lantiq/clk.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> --- linux-next-20211112.orig/arch/mips/lantiq/clk.c
> +++ linux-next-20211112/arch/mips/lantiq/clk.c
> @@ -158,6 +158,12 @@ void clk_deactivate(struct clk *clk)
> }
> EXPORT_SYMBOL(clk_deactivate);
>
> +struct clk *clk_get_parent(struct clk *clk)
> +{
> + return NULL;
> +}
> +EXPORT_SYMBOL(clk_get_parent);
> +
> static inline u32 get_counter_resolution(void)
> {
> u32 res;

applied to mips-fixes.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]