2005-10-26 21:48:37

by Richard Knutsson

Subject: [PATCH 2.6.14-rc5] drivers/net/dgrs.c: Fix potential "unused variable"-warning.

Just a cosmetic change to prevent compiler-warning about unused variable (+ save 2 or 4 bytes of memory).

BTW, the authors mail-address seems invalid.

Signed-off-by: Richard Knutsson

---

diff -uNr a/drivers/net/dgrs.c b/drivers/net/dgrs.c
--- a/drivers/net/dgrs.c 2005-08-29 01:41:01.000000000 +0200
+++ b/drivers/net/dgrs.c 2005-10-26 15:53:43.000000000 +0200
@@ -1549,7 +1549,7 @@
static int __init dgrs_init_module (void)
{
int i;
- int eisacount = 0, pcicount = 0;
+ int count = 0;

/*
* Command line variable overrides
@@ -1591,14 +1591,14 @@
* Find and configure all the cards
*/
#ifdef CONFIG_EISA
- eisacount = eisa_driver_register(&dgrs_eisa_driver);
- if (eisacount < 0)
- return eisacount;
+ count = eisa_driver_register(&dgrs_eisa_driver);
+ if (count < 0)
+ return count;
#endif
#ifdef CONFIG_PCI
- pcicount = pci_register_driver(&dgrs_pci_driver);
- if (pcicount)
- return pcicount;
+ count = pci_register_driver(&dgrs_pci_driver);
+ if (count)
+ return count;
#endif
return 0;
}

2005-10-28 16:38:54

by Jeff Garzik

Subject: Re: [PATCH 2.6.14-rc5] drivers/net/dgrs.c: Fix potential "unused variable"-warning.

Richard Knutsson wrote:
> Just a cosmetic change to prevent compiler-warning about unused variable
> (+ save 2 or 4 bytes of memory).
>
> BTW, the authors mail-address seems invalid.
>
> Signed-off-by: Richard Knutsson
>
> ---
>
> diff -uNr a/drivers/net/dgrs.c b/drivers/net/dgrs.c
> --- a/drivers/net/dgrs.c 2005-08-29 01:41:01.000000000 +0200
> +++ b/drivers/net/dgrs.c 2005-10-26 15:53:43.000000000 +0200
> @@ -1549,7 +1549,7 @@
> static int __init dgrs_init_module (void)
> {
> int i;
> - int eisacount = 0, pcicount = 0;
> + int count = 0;

no need to initialize the variable

2005-10-28 17:12:32

by Richard Knutsson

Subject: Re: [PATCH 2.6.14-rc5] drivers/net/dgrs.c: Fix potential "unused variable"-warning.

Jeff Garzik wrote:

> Richard Knutsson wrote:
>
>> diff -uNr a/drivers/net/dgrs.c b/drivers/net/dgrs.c
>> --- a/drivers/net/dgrs.c 2005-08-29 01:41:01.000000000 +0200
>> +++ b/drivers/net/dgrs.c 2005-10-26 15:53:43.000000000 +0200
>> @@ -1549,7 +1549,7 @@
>> static int __init dgrs_init_module (void)
>> {
>> int i;
>> - int eisacount = 0, pcicount = 0;
>> + int count = 0;
>
>
> no need to initialize the variable

Yeah, you are right. Saw it after I sent the mail and thought it would
be cluttering the mail-list just to say so.
Thanks for noticing. :)

*Note to 'self:
Check and _recheck_ patch before sending it*
/Richard

PS
Sorry about the bounced mail from [email protected], did not
realize it were an old address.