2019-11-07 04:04:32

by Stephen Rothwell

[permalink] [raw]
Subject: linux-next: build warning after merge of the scsi tree

Hi all,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_cpumask_of_node_init':
drivers/scsi/lpfc/lpfc_init.c:6020:6: warning: the address of 'cpu_all_bits' will always evaluate as 'true' [-Waddress]
6020 | if (!cpumask_of_node(numa_node))
| ^

Introduced by commit

dcaa21367938 ("scsi: lpfc: Change default IRQ model on AMD architectures")

--
Cheers,
Stephen Rothwell


Attachments:
(No filename) (499.00 B)
OpenPGP digital signature

2019-11-07 15:52:32

by Bart Van Assche

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the scsi tree

On 11/6/19 8:01 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
>
> drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_cpumask_of_node_init':
> drivers/scsi/lpfc/lpfc_init.c:6020:6: warning: the address of 'cpu_all_bits' will always evaluate as 'true' [-Waddress]
> 6020 | if (!cpumask_of_node(numa_node))
> | ^
>
> Introduced by commit
>
> dcaa21367938 ("scsi: lpfc: Change default IRQ model on AMD architectures")

Thanks Stephen for this report. A candidate fix has been posted:
https://lore.kernel.org/linux-scsi/[email protected]/T/#u

Bart.


2019-11-08 23:05:56

by James Smart

[permalink] [raw]
Subject: Re: linux-next: build warning after merge of the scsi tree

On 11/7/2019 7:51 AM, Bart Van Assche wrote:
> On 11/6/19 8:01 PM, Stephen Rothwell wrote:
>> Hi all,
>>
>> After merging the scsi tree, today's linux-next build (powerpc
>> ppc64_defconfig) produced this warning:
>>
>> drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_cpumask_of_node_init':
>> drivers/scsi/lpfc/lpfc_init.c:6020:6: warning: the address of
>> 'cpu_all_bits' will always evaluate as 'true' [-Waddress]
>> ? 6020 |? if (!cpumask_of_node(numa_node))
>> ?????? |????? ^
>>
>> Introduced by commit
>>
>> ?? dcaa21367938 ("scsi: lpfc: Change default IRQ model on AMD
>> architectures")
>
> Thanks Stephen for this report. A candidate fix has been posted:
> https://lore.kernel.org/linux-scsi/[email protected]/T/#u
>
>
> Bart.
>
>

See revised fix at:
https://marc.info/?l=linux-scsi&m=157325403920775&w=2

-- james