2005-11-01 08:13:29

by Michael Krufky

[permalink] [raw]
Subject: [PATCH 03/37] dvb: stv0299: revert improper method




Attachments:
2359.patch (1.65 kB)

2005-11-03 03:26:29

by Andrew Morton

[permalink] [raw]
Subject: Re: [PATCH 03/37] dvb: stv0299: revert improper method

Michael Krufky <[email protected]> wrote:
>
> + if (state->errmode != STATUS_UCBLOCKS) *ucblocks = 0;
> + else *ucblocks = (stv0299_readreg (state, 0x1d) << 8) | stv0299_readreg (state, 0x1e);

Preferred kernel tyle is

if (expr)
statement;
else
statement;

please.