2005-11-10 21:26:12

by Michael Krufky

[permalink] [raw]
Subject: Re: [Patch 17/20] V4L (963.1) hybrid v4l/dvb: remove duplicated code

[email protected] wrote:

>From: Michael Krufky <[email protected]>
>
>- The following patch caused a duplicated code in cx88-dvb.c
>
>Signed-off-by: Michael Krufky <[email protected]>
>
> drivers/media/video/cx88/cx88-dvb.c | 3 ---
> 1 files changed, 3 deletions(-)
>
Mauro chopped my description on this patch...... The description above
doesnt make any sense... It SHOULD read as follows:

The following patch caused some duplicated code in cx88-dvb.c:
[PATCH] v4l: 634: implemented tuner set standby on cx88 init

The cx88-dvb.c portion of this patch was already applied
in an earlier patch, entitled:
[PATCH] v4l: fixup on cx88_dvb for Dvico HDTV5 Gold

I love quilt and all, but AFAIK, no tool is 100% perfect for catching
oversights like this.

The non-overlapping portions of each of these patches are still needed,
and must not be discarded, so rather than reverting old patches, please
just apply this fixup patch to remove the duplicated code.

Signed-off-by: Michael Krufky <[email protected]>


Now, maybe my description was wordy, but the one-liner doesnt tell us
ANYTHING meaningful.

Thanks.

--
Michael Krufky