2005-11-11 12:56:55

by Gabriel A. Devenyi

Subject: [RESEND] [PATCH] drivers/net/wireless/airo.c unsigned comparason

fid is declared as a u32 (unsigned int), and then a few lines later, it is checked for a value < 0, which is clearly useless.
In the two locations this function is used, in one it is *explicitly* given a negative number, which would be ignored with the
current definition.

Thanks to LinuxICC (http://linuxicc.sf.net).

This patch applies to linus' git tree as of 03.11.2005

Signed-off-by: Gabriel A. Devenyi <[email protected]>

diff --git a/drivers/net/wireless/airo.c b/drivers/net/wireless/airo.c
index 750c016..849ac88 100644
--- a/drivers/net/wireless/airo.c
+++ b/drivers/net/wireless/airo.c
@@ -2040,7 +2040,7 @@ static int mpi_send_packet (struct net_d
return 1;
}

-static void get_tx_error(struct airo_info *ai, u32 fid)
+static void get_tx_error(struct airo_info *ai, s32 fid)
{
u16 status;


--
Gabriel A. Devenyi
[email protected]

2005-12-01 07:39:38

by Jeff Garzik

Subject: Re: [RESEND] [PATCH] drivers/net/wireless/airo.c unsigned comparason

Gabriel A. Devenyi wrote:
> fid is declared as a u32 (unsigned int), and then a few lines later, it
> is checked for a value < 0, which is clearly useless.
> In the two locations this function is used, in one it is *explicitly*
> given a negative number, which would be ignored with the
> current definition.
>
> Thanks to LinuxICC (http://linuxicc.sf.net).
>
> This patch applies to linus' git tree as of 03.11.2005
>
> Signed-off-by: Gabriel A. Devenyi <[email protected]>


[jgarzik@pretzel netdev-2.6]$ git-applymbox /g/tmp/mbox ~/info/signoff.txt
1 patch(es) to process.

Applying 'drivers/net/wireless/airo.c unsigned comparason'

fatal: corrupt patch at line 8