2015-08-10 21:41:33

by Junsu Shin

Subject: [PATCH v2] Staging: media: davinci_vpfe: Fix over 80 characters coding style issue

This is a patch to the dm365_ipipe.c that fixes over 80 characters warning detected.

Signed-off-by: Junsu Shin <[email protected]>
---
drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
index 1bbb90c..a474adf 100644
--- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
+++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
@@ -1536,8 +1536,9 @@ ipipe_get_format(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
* @fse: pointer to v4l2_subdev_frame_size_enum structure.
*/
static int
-ipipe_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config *cfg,
- struct v4l2_subdev_frame_size_enum *fse)
+ipipe_enum_frame_size(struct v4l2_subdev *sd,
+ struct v4l2_subdev_pad_config *cfg,
+ struct v4l2_subdev_frame_size_enum *fse)
{
struct vpfe_ipipe_device *ipipe = v4l2_get_subdevdata(sd);
struct v4l2_mbus_framefmt format;
--
1.9.1

2015-11-09 20:56:12

by Laurent Pinchart

Subject: Re: [PATCH v2] Staging: media: davinci_vpfe: Fix over 80 characters coding style issue

Hello Junsu,

Thank you for the patch.

On Monday 10 August 2015 16:40:59 Junsu Shin wrote:
> This is a patch to the dm365_ipipe.c that fixes over 80 characters warning
> detected.

It's a bit ironic to submit a patch fixing a 80 characters limit issue and
having a commit message that is larger than 72 characters per line :-)

Anyway, I've wrapped the commit message to 72 columns and applied the patch to
my tree.

> Signed-off-by: Junsu Shin <[email protected]>
> ---
> drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c index 1bbb90c..a474adf
> 100644
> --- a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> +++ b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c
> @@ -1536,8 +1536,9 @@ ipipe_get_format(struct v4l2_subdev *sd, struct
> v4l2_subdev_pad_config *cfg, * @fse: pointer to v4l2_subdev_frame_size_enum
> structure.
> */
> static int
> -ipipe_enum_frame_size(struct v4l2_subdev *sd, struct v4l2_subdev_pad_config
> *cfg, - struct v4l2_subdev_frame_size_enum *fse)
> +ipipe_enum_frame_size(struct v4l2_subdev *sd,
> + struct v4l2_subdev_pad_config *cfg,
> + struct v4l2_subdev_frame_size_enum *fse)
> {
> struct vpfe_ipipe_device *ipipe = v4l2_get_subdevdata(sd);
> struct v4l2_mbus_framefmt format;

--
Regards,

Laurent Pinchart