2014-06-18 23:09:13

by Dmitry Torokhov

Subject: [PATCH] MAINTAINERS: add entry for VMware Balloon driver

Signed-off-by: Dmitry Torokhov <[email protected]>
---
MAINTAINERS | 6 ++++++
drivers/misc/vmw_balloon.c | 2 +-
2 files changed, 7 insertions(+), 1 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 6c484ac..3a446e8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9645,6 +9645,12 @@ L: [email protected]
S: Supported
F: arch/x86/kernel/cpu/vmware.c

+VMWARE BALLOON DRIVER
+M: "VMware, Inc." <[email protected]>
+L: [email protected]
+S: Maintained
+F: drivers/misc/vmw_balloon.c
+
VMWARE VMXNET3 ETHERNET DRIVER
M: Shreyas Bhatewara <[email protected]>
M: "VMware, Inc." <[email protected]>
diff --git a/drivers/misc/vmw_balloon.c b/drivers/misc/vmw_balloon.c
index 2421835..1a4dc2a 100644
--- a/drivers/misc/vmw_balloon.c
+++ b/drivers/misc/vmw_balloon.c
@@ -17,7 +17,7 @@
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
- * Maintained by: Dmitry Torokhov <[email protected]>
+ * Maintained by: [email protected]
*/

/*
--
1.7.4.1

2014-06-18 23:13:45

by Greg Kroah-Hartman

Subject: Re: [PATCH] MAINTAINERS: add entry for VMware Balloon driver

On Wed, Jun 18, 2014 at 04:09:01PM -0700, Dmitry Torokhov wrote:
> Signed-off-by: Dmitry Torokhov <[email protected]>
> ---
> MAINTAINERS | 6 ++++++
> drivers/misc/vmw_balloon.c | 2 +-
> 2 files changed, 7 insertions(+), 1 deletions(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6c484ac..3a446e8 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9645,6 +9645,12 @@ L: [email protected]
> S: Supported
> F: arch/x86/kernel/cpu/vmware.c
>
> +VMWARE BALLOON DRIVER
> +M: "VMware, Inc." <[email protected]>
> +L: [email protected]
> +S: Maintained
> +F: drivers/misc/vmw_balloon.c

I really hate having a "alias" as a maintainer, and not a "real" name.
Kernel development is done by individuals, we don't have companies as
authors or signed-off-by lines, we have developers.

So I will not accept this, sorry. Please find a real person who is
willing to maintain this code, or just mark it unsupported.

thanks,

greg k-h

2014-06-18 23:19:27

by Dmitry Torokhov

Subject: Re: [PATCH] MAINTAINERS: add entry for VMware Balloon driver

On Wednesday, June 18, 2014 04:17:42 PM Greg Kroah-Hartman wrote:
> On Wed, Jun 18, 2014 at 04:09:01PM -0700, Dmitry Torokhov wrote:
> > Signed-off-by: Dmitry Torokhov <[email protected]>
> > ---
> >
> > MAINTAINERS | 6 ++++++
> > drivers/misc/vmw_balloon.c | 2 +-
> > 2 files changed, 7 insertions(+), 1 deletions(-)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 6c484ac..3a446e8 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -9645,6 +9645,12 @@ L: [email protected]
> >
> > S: Supported
> > F: arch/x86/kernel/cpu/vmware.c
> >
> > +VMWARE BALLOON DRIVER
> > +M: "VMware, Inc." <[email protected]>
> > +L: [email protected]
> > +S: Maintained
> > +F: drivers/misc/vmw_balloon.c
>
> I really hate having a "alias" as a maintainer, and not a "real" name.
> Kernel development is done by individuals, we don't have companies as
> authors or signed-off-by lines, we have developers.
>
> So I will not accept this, sorry. Please find a real person who is
> willing to maintain this code, or just mark it unsupported.
>

OK, fair enough, we'll find a real name to attach here.

Thanks,
Dmitry

2014-06-18 23:28:25

by Joe Perches

Subject: Re: [PATCH] MAINTAINERS: add entry for VMware Balloon driver

On Wed, 2014-06-18 at 16:19 -0700, Dmitry Torokhov wrote:
> On Wednesday, June 18, 2014 04:17:42 PM Greg Kroah-Hartman wrote:
> > On Wed, Jun 18, 2014 at 04:09:01PM -0700, Dmitry Torokhov wrote:
> > > Signed-off-by: Dmitry Torokhov <[email protected]>
> > > ---
> > >
> > > MAINTAINERS | 6 ++++++
> > > drivers/misc/vmw_balloon.c | 2 +-
> > > 2 files changed, 7 insertions(+), 1 deletions(-)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 6c484ac..3a446e8 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -9645,6 +9645,12 @@ L: [email protected]
> > >
> > > S: Supported
> > > F: arch/x86/kernel/cpu/vmware.c
> > >
> > > +VMWARE BALLOON DRIVER
> > > +M: "VMware, Inc." <[email protected]>
> > > +L: [email protected]
> > > +S: Maintained
> > > +F: drivers/misc/vmw_balloon.c
> >
> > I really hate having a "alias" as a maintainer, and not a "real" name.
> > Kernel development is done by individuals, we don't have companies as
> > authors or signed-off-by lines, we have developers.
> >
> > So I will not accept this, sorry. Please find a real person who is
> > willing to maintain this code, or just mark it unsupported.
> >
>
> OK, fair enough, we'll find a real name to attach here.

It's definitely better to have a person's name there but
there are many company exploders/aliases in MAINTAINERS.

There already is a [email protected] too.

MAINTAINERS:M: Adaptec OEM Raid Solutions <[email protected]>
MAINTAINERS:M: [email protected]
MAINTAINERS:M: Intel Linux Wireless <[email protected]>
MAINTAINERS:M: Intel SCU Linux support <[email protected]>
MAINTAINERS:M: [email protected]
MAINTAINERS:M: [email protected]
MAINTAINERS:M: Linux NICS <[email protected]>
MAINTAINERS:M: [email protected]
MAINTAINERS:M: [email protected]
MAINTAINERS:M: Solarflare linux maintainers <[email protected]>
MAINTAINERS:M: [email protected]
MAINTAINERS:M: Support Opensource <[email protected]>
MAINTAINERS:M: "VMware, Inc." <[email protected]>

2014-06-18 23:45:36

by Greg Kroah-Hartman

Subject: Re: [PATCH] MAINTAINERS: add entry for VMware Balloon driver

On Wed, Jun 18, 2014 at 04:28:20PM -0700, Joe Perches wrote:
> On Wed, 2014-06-18 at 16:19 -0700, Dmitry Torokhov wrote:
> > On Wednesday, June 18, 2014 04:17:42 PM Greg Kroah-Hartman wrote:
> > > On Wed, Jun 18, 2014 at 04:09:01PM -0700, Dmitry Torokhov wrote:
> > > > Signed-off-by: Dmitry Torokhov <[email protected]>
> > > > ---
> > > >
> > > > MAINTAINERS | 6 ++++++
> > > > drivers/misc/vmw_balloon.c | 2 +-
> > > > 2 files changed, 7 insertions(+), 1 deletions(-)
> > > >
> > > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > > index 6c484ac..3a446e8 100644
> > > > --- a/MAINTAINERS
> > > > +++ b/MAINTAINERS
> > > > @@ -9645,6 +9645,12 @@ L: [email protected]
> > > >
> > > > S: Supported
> > > > F: arch/x86/kernel/cpu/vmware.c
> > > >
> > > > +VMWARE BALLOON DRIVER
> > > > +M: "VMware, Inc." <[email protected]>
> > > > +L: [email protected]
> > > > +S: Maintained
> > > > +F: drivers/misc/vmw_balloon.c
> > >
> > > I really hate having a "alias" as a maintainer, and not a "real" name.
> > > Kernel development is done by individuals, we don't have companies as
> > > authors or signed-off-by lines, we have developers.
> > >
> > > So I will not accept this, sorry. Please find a real person who is
> > > willing to maintain this code, or just mark it unsupported.
> > >
> >
> > OK, fair enough, we'll find a real name to attach here.
>
> It's definitely better to have a person's name there but
> there are many company exploders/aliases in MAINTAINERS.
>
> There already is a [email protected] too.
>
> MAINTAINERS:M: Adaptec OEM Raid Solutions <[email protected]>
> MAINTAINERS:M: [email protected]
> MAINTAINERS:M: Intel Linux Wireless <[email protected]>
> MAINTAINERS:M: Intel SCU Linux support <[email protected]>
> MAINTAINERS:M: [email protected]
> MAINTAINERS:M: [email protected]
> MAINTAINERS:M: Linux NICS <[email protected]>
> MAINTAINERS:M: [email protected]
> MAINTAINERS:M: [email protected]
> MAINTAINERS:M: Solarflare linux maintainers <[email protected]>
> MAINTAINERS:M: [email protected]
> MAINTAINERS:M: Support Opensource <[email protected]>
> MAINTAINERS:M: "VMware, Inc." <[email protected]>

Yeah, and in every case I've ever had to deal with one, it's never
worked. People are maintainers, not email aliases.

greg k-h