2017-12-21 15:38:40

by Rasmus Villemoes

Subject: [PATCH] ARM: dts: ls1021a: add nodes for on-chip ram

Signed-off-by: Rasmus Villemoes <[email protected]>
---
arch/arm/boot/dts/ls1021a.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index bd6622f10046..6f53e6aefb63 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -748,5 +748,21 @@
<0000 0 0 3 &gic GIC_SPI 191 IRQ_TYPE_LEVEL_HIGH>,
<0000 0 0 4 &gic GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>;
};
+
+ ocram1: sram@10000000 {
+ compatible = "mmio-sram";
+ reg = <0x0 0x10000000 0x0 0x10000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0x0 0x10000000 0x10000>;
+ };
+
+ ocram2: sram@10010000 {
+ compatible = "mmio-sram";
+ reg = <0x0 0x10010000 0x0 0x10000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0x0 0x10010000 0x10000>;
+ };
};
};
--
2.7.4

2017-12-26 08:57:01

by Shawn Guo

Subject: Re: [PATCH] ARM: dts: ls1021a: add nodes for on-chip ram

On Thu, Dec 21, 2017 at 04:38:18PM +0100, Rasmus Villemoes wrote:
> Signed-off-by: Rasmus Villemoes <[email protected]>

Empty commit log is not welcomed.

> ---
> arch/arm/boot/dts/ls1021a.dtsi | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index bd6622f10046..6f53e6aefb63 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -748,5 +748,21 @@
> <0000 0 0 3 &gic GIC_SPI 191 IRQ_TYPE_LEVEL_HIGH>,
> <0000 0 0 4 &gic GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>;
> };
> +
> + ocram1: sram@10000000 {
> + compatible = "mmio-sram";
> + reg = <0x0 0x10000000 0x0 0x10000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0x0 0x10000000 0x10000>;
> + };
> +
> + ocram2: sram@10010000 {
> + compatible = "mmio-sram";
> + reg = <0x0 0x10010000 0x0 0x10000>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x0 0x0 0x10010000 0x10000>;
> + };

Why split one continuous sram into two nodes?

Shawn

> };
> };
> --
> 2.7.4
>

2018-01-03 15:46:22

by Rasmus Villemoes

Subject: [PATCH v2] ARM: dts: ls1021a: add nodes for on-chip ram

Although the two nodes constitute one contiguous 128K region, still
describe them separately:

- That's how they are described in the reference manual: "Each OCRAM
occupies a 64 KB of address region...", and the names ocram1 and
ocram2 are also as used in the manual.

- The two areas are treated differently by the boot ROM code: OCRAM2 is
zero-initialized, while, again quoting the RM, "software must perform
the zero initialization of OCRAM1."

Signed-off-by: Rasmus Villemoes <[email protected]>
---
v2: add changelog explaining the split in two nodes.

arch/arm/boot/dts/ls1021a.dtsi | 16 ++++++++++++++++
1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index 96aa7752dd0d..7bb5896b3726 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -748,5 +748,21 @@
<0000 0 0 3 &gic GIC_SPI 191 IRQ_TYPE_LEVEL_HIGH>,
<0000 0 0 4 &gic GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>;
};
+
+ ocram1: sram@10000000 {
+ compatible = "mmio-sram";
+ reg = <0x0 0x10000000 0x0 0x10000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0x0 0x10000000 0x10000>;
+ };
+
+ ocram2: sram@10010000 {
+ compatible = "mmio-sram";
+ reg = <0x0 0x10010000 0x0 0x10000>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges = <0x0 0x0 0x10010000 0x10000>;
+ };
};
};
--
2.7.4

2018-01-19 10:55:20

by Rasmus Villemoes

Subject: Re: [PATCH v2] ARM: dts: ls1021a: add nodes for on-chip ram

On 2018-01-03 16:45, Rasmus Villemoes wrote:
> Although the two nodes constitute one contiguous 128K region, still
> describe them separately:
>
> - That's how they are described in the reference manual: "Each OCRAM
> occupies a 64 KB of address region...", and the names ocram1 and
> ocram2 are also as used in the manual.
>
> - The two areas are treated differently by the boot ROM code: OCRAM2 is
> zero-initialized, while, again quoting the RM, "software must perform
> the zero initialization of OCRAM1."

ping

2018-01-23 07:13:21

by Shawn Guo

Subject: Re: [PATCH v2] ARM: dts: ls1021a: add nodes for on-chip ram

On Wed, Jan 03, 2018 at 04:45:45PM +0100, Rasmus Villemoes wrote:
> Although the two nodes constitute one contiguous 128K region, still
> describe them separately:
>
> - That's how they are described in the reference manual: "Each OCRAM
> occupies a 64 KB of address region...", and the names ocram1 and
> ocram2 are also as used in the manual.
>
> - The two areas are treated differently by the boot ROM code: OCRAM2 is
> zero-initialized, while, again quoting the RM, "software must perform
> the zero initialization of OCRAM1."
>
> Signed-off-by: Rasmus Villemoes <[email protected]>

Applied, thanks.