>Subject: [git pull 02/14] Add Wistron driver
>
>Input: add Wistron driver
>
>A driver for laptop buttons using an x86 BIOS interface that is
>apparently used on quite a few laptops and seems to be originating
>from Wistron.
>
>This driver currently "knows" only about Fujitsu-Siemens Amilo
>Pro V2000
>(i.e. it can detect the laptop using DMI and it contains the
>keycode->key meaning mapping for this laptop) and Xeron SonicPro X 155G
>(probably can't be reliably autodetected, requires a module parameter),
>adding other laptops should be easy.
>
>In addition to reporting button presses to the input layer the driver
>also allows enabling/disabling the embedded wireless NIC (using the
>"Wifi" button); this is done using the same BIOS interface, so it seems
>only logical to keep the implementation together. Any flexibility
>possibly gained by allowing users to remap the function of the "Wifi"
>button is IMHO not worth it when weighted against the necessity to run
>an user-space daemon to convert button presses to wifi state changes.
>
>Signed-off-by: Miloslav Trmac <[email protected]>
>Signed-off-by: Dmitry Torokhov <[email protected]>
>---
>
I just tested module wistron_btn on one Acer Aspire laptop after
adding one dmi entry. The wistron_btn found BIOS interfaces.
One visible error is the bluetooth light won't turn on upon
stroking bluetooth button.
Without wistron_btn module, the bluetooth light works.
with acpi enabled, I didn't try acpi disabled)
wistron_btn polls a cmos address to detect hotkey event. It
is not necessary, because there do have ACPI interrupt triggered upon
hotkeys.
So, my suggestion is to disable this module when ACPI enabled.
We need to implement hotkey support from ACPI subsystem for my
Acer aspire laptop.
--- linux-2.6.15-rc3/drivers/input/misc/Kconfig.0 2005-12-02
10:08:33.000000000 -0700
+++ linux-2.6.15-rc3/drivers/input/misc/Kconfig 2005-12-02
10:08:58.000000000 -0700
@@ -42,7 +42,7 @@
config INPUT_WISTRON_BTNS
tristate "x86 Wistron laptop button interface"
- depends on X86 && !X86_64
+ depends on X86 && !X86_64 && !ACPI
help
Say Y here for support of Winstron laptop button interface,
used on
laptops of various brands, including Acer and Fujitsu-Siemens.
On 12/2/05, Yu, Luming <[email protected]> wrote:
> I just tested module wistron_btn on one Acer Aspire laptop after
> adding one dmi entry. The wistron_btn found BIOS interfaces.
> One visible error is the bluetooth light won't turn on upon
> stroking bluetooth button.
> Without wistron_btn module, the bluetooth light works.
> with acpi enabled, I didn't try acpi disabled)
>
Did you add the new keymap table with KE_BLUETOOTH to go with that DMI entry?
> wistron_btn polls a cmos address to detect hotkey event. It
> is not necessary, because there do have ACPI interrupt triggered upon
> hotkeys.
>
Unfortunately ACPI does not route these events through the input layer
so aside from special buttons (like sleep) it is not very useful.
> So, my suggestion is to disable this module when ACPI enabled.
> We need to implement hotkey support from ACPI subsystem for my
> Acer aspire laptop.
I do not agree.
--
Dmitry
Yu, Luming wrote:
> I just tested module wistron_btn on one Acer Aspire laptop after
> adding one dmi entry. The wistron_btn found BIOS interfaces.
> One visible error is the bluetooth light won't turn on upon
> stroking bluetooth button.
> Without wistron_btn module, the bluetooth light works.
> with acpi enabled, I didn't try acpi disabled)
>
> wistron_btn polls a cmos address to detect hotkey event. It
> is not necessary, because there do have ACPI interrupt triggered upon
> hotkeys.
There are many different laptops using similar interfaces.
It is a mess :(
If your laptop provides the hotkey events via ACPI, simply don't use
wistron_btns.
> So, my suggestion is to disable this module when ACPI enabled.
I have a laptop that needs this module (hotkeys are not supported via
ACPI), but supports ACPI.
Mirek