2019-09-05 09:44:54

by jamestai.sky

Subject: [PATCH] dt-bindings: arm: Convert Realtek board/soc bindings to json-schema

From: "james.tai" <[email protected]>

Convert Realtek SoC bindings to DT schema format using json-schema.

Signed-off-by: james.tai <[email protected]>
---
.../devicetree/bindings/arm/realtek.txt | 22 -------------------
.../devicetree/bindings/arm/realtek.yaml | 17 ++++++++++++++
2 files changed, 17 insertions(+), 22 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/arm/realtek.txt
create mode 100644 Documentation/devicetree/bindings/arm/realtek.yaml

diff --git a/Documentation/devicetree/bindings/arm/realtek.txt b/Documentation/devicetree/bindings/arm/realtek.txt
deleted file mode 100644
index 95839e19ae92..000000000000
--- a/Documentation/devicetree/bindings/arm/realtek.txt
+++ /dev/null
@@ -1,22 +0,0 @@
-Realtek platforms device tree bindings
---------------------------------------
-
-
-RTD1295 SoC
-===========
-
-Required root node properties:
-
- - compatible : must contain "realtek,rtd1295"
-
-
-Root node property compatible must contain, depending on board:
-
- - MeLE V9: "mele,v9"
- - ProBox2 AVA: "probox2,ava"
- - Zidoo X9S: "zidoo,x9s"
-
-
-Example:
-
- compatible = "zidoo,x9s", "realtek,rtd1295";
diff --git a/Documentation/devicetree/bindings/arm/realtek.yaml b/Documentation/devicetree/bindings/arm/realtek.yaml
new file mode 100644
index 000000000000..ad9b13bc42f0
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/realtek.yaml
@@ -0,0 +1,17 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/realtek.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Realtek platforms device tree bindings
+
+properties:
+ compatible:
+ oneOf:
+ items:
+ - enum:
+ - mele,v9
+ - probox2,ava
+ - zidoo,x9s
+ - const: realtek,rtd1295
--
2.17.1

2019-09-05 11:59:00

by Rob Herring

Subject: Re: [PATCH] dt-bindings: arm: Convert Realtek board/soc bindings to json-schema

On Thu, Sep 5, 2019 at 9:19 AM <[email protected]> wrote:
>
> From: "james.tai" <[email protected]>
>
> Convert Realtek SoC bindings to DT schema format using json-schema.
>
> Signed-off-by: james.tai <[email protected]>
> ---
> .../devicetree/bindings/arm/realtek.txt | 22 -------------------
> .../devicetree/bindings/arm/realtek.yaml | 17 ++++++++++++++
> 2 files changed, 17 insertions(+), 22 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/arm/realtek.txt
> create mode 100644 Documentation/devicetree/bindings/arm/realtek.yaml

I've already submitted a patch for this that's *still* waiting on
Andreas to apply or comment on the licensing.

Also, your patch isn't valid schema. Please check with 'make dt_binding_check'.

2019-09-11 07:21:51

by James Tai [戴志峰]

Subject: RE: [PATCH] dt-bindings: arm: Convert Realtek board/soc bindings to json-schema

> Subject: Re: [PATCH] dt-bindings: arm: Convert Realtek board/soc bindings to
> json-schema
>
> On Thu, Sep 5, 2019 at 9:19 AM <[email protected]> wrote:
> >
> > From: "james.tai" <[email protected]>
> >
> > Convert Realtek SoC bindings to DT schema format using json-schema.
> >
> > Signed-off-by: james.tai <[email protected]>
> > ---
> > .../devicetree/bindings/arm/realtek.txt | 22 -------------------
> > .../devicetree/bindings/arm/realtek.yaml | 17 ++++++++++++++
> > 2 files changed, 17 insertions(+), 22 deletions(-) delete mode
> > 100644 Documentation/devicetree/bindings/arm/realtek.txt
> > create mode 100644
> Documentation/devicetree/bindings/arm/realtek.yaml
>
> I've already submitted a patch for this that's *still* waiting on Andreas to apply
> or comment on the licensing.

Thanks for your reply.

> Also, your patch isn't valid schema. Please check with 'make
> dt_binding_check'.
>
I will check with 'make dt_binding_check'.
Thanks!

> ------Please consider the environment before printing this e-mail.