2005-12-20 08:55:10

by Yasunori Goto

Subject: [Patch] New zone ZONE_EASY_RECLAIM take 4. (Change PageHighMem())[8/8]

This patch is change PageHighMem()'s definition for i386.
Easy reclaim zone is treated like highmem on i386.

This is new patch at take 4.

Signed-off-by: Yasunori Goto <[email protected]>

Index: zone_reclaim/include/linux/page-flags.h
===================================================================
--- zone_reclaim.orig/include/linux/page-flags.h 2005-12-15 21:01:09.000000000 +0900
+++ zone_reclaim/include/linux/page-flags.h 2005-12-15 21:24:07.000000000 +0900
@@ -265,7 +265,7 @@ extern void __mod_page_state_offset(unsi
#define TestSetPageSlab(page) test_and_set_bit(PG_slab, &(page)->flags)

#ifdef CONFIG_HIGHMEM
-#define PageHighMem(page) is_highmem(page_zone(page))
+#define PageHighMem(page) is_higher_zone(page_zone(page))
#else
#define PageHighMem(page) 0 /* needed to optimize away at compile time */
#endif

--
Yasunori Goto

2006-01-03 21:41:11

by Joel Schopp

Subject: Re: [Patch] New zone ZONE_EASY_RECLAIM take 4. (Change PageHighMem())[8/8]

> This patch is change PageHighMem()'s definition for i386.
> Easy reclaim zone is treated like highmem on i386.

This doesn't look like an i386 file, it looks like you are changing it
for all architectures that have HIGHMEM (do any other archs use
highmeme?). This may be fine, just wanted you to be aware.

>
> This is new patch at take 4.
>
> Signed-off-by: Yasunori Goto <[email protected]>
>
> Index: zone_reclaim/include/linux/page-flags.h
> ===================================================================
> --- zone_reclaim.orig/include/linux/page-flags.h 2005-12-15 21:01:09.000000000 +0900
> +++ zone_reclaim/include/linux/page-flags.h 2005-12-15 21:24:07.000000000 +0900
> @@ -265,7 +265,7 @@ extern void __mod_page_state_offset(unsi
> #define TestSetPageSlab(page) test_and_set_bit(PG_slab, &(page)->flags)
>
> #ifdef CONFIG_HIGHMEM
> -#define PageHighMem(page) is_highmem(page_zone(page))
> +#define PageHighMem(page) is_higher_zone(page_zone(page))
> #else
> #define PageHighMem(page) 0 /* needed to optimize away at compile time */
> #endif
>

2006-01-05 05:54:52

by Yasunori Goto

Subject: Re: [Patch] New zone ZONE_EASY_RECLAIM take 4. (Change PageHighMem())[8/8]

> > This patch is change PageHighMem()'s definition for i386.
> > Easy reclaim zone is treated like highmem on i386.
>
> This doesn't look like an i386 file, it looks like you are changing it
> for all architectures that have HIGHMEM (do any other archs use
> highmeme?). This may be fine, just wanted you to be aware.

Right. My description was wrong. This is for all arch.

The first purpose of his patch is to give i386 environment for
Kame-san's remove patch. This description came from it.

Sorry.



>
> >
> > This is new patch at take 4.
> >
> > Signed-off-by: Yasunori Goto <[email protected]>
> >
> > Index: zone_reclaim/include/linux/page-flags.h
> > ===================================================================
> > --- zone_reclaim.orig/include/linux/page-flags.h 2005-12-15 21:01:09.000000000 +0900
> > +++ zone_reclaim/include/linux/page-flags.h 2005-12-15 21:24:07.000000000 +0900
> > @@ -265,7 +265,7 @@ extern void __mod_page_state_offset(unsi
> > #define TestSetPageSlab(page) test_and_set_bit(PG_slab, &(page)->flags)
> >
> > #ifdef CONFIG_HIGHMEM
> > -#define PageHighMem(page) is_highmem(page_zone(page))
> > +#define PageHighMem(page) is_higher_zone(page_zone(page))
> > #else
> > #define PageHighMem(page) 0 /* needed to optimize away at compile time */
> > #endif
> >
>
>

--
Yasunori Goto