2019-04-02 09:45:03

by Peng Fan

Subject: [PATCH] mm: __pagevec_lru_add_fn: typo fix

There is no function named munlock_vma_pages, correct it to
munlock_vma_page.

Signed-off-by: Peng Fan <[email protected]>
---
mm/swap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/swap.c b/mm/swap.c
index 301ed4e04320..3a75722e68a9 100644
--- a/mm/swap.c
+++ b/mm/swap.c
@@ -867,7 +867,7 @@ static void __pagevec_lru_add_fn(struct page *page, struct lruvec *lruvec,
SetPageLRU(page);
/*
* Page becomes evictable in two ways:
- * 1) Within LRU lock [munlock_vma_pages() and __munlock_pagevec()].
+ * 1) Within LRU lock [munlock_vma_page() and __munlock_pagevec()].
* 2) Before acquiring LRU lock to put the page to correct LRU and then
* a) do PageLRU check with lock [check_move_unevictable_pages]
* b) do PageLRU check before lock [clear_page_mlock]
--
2.16.4

2019-04-03 07:47:14

by Vlastimil Babka

Subject: Re: [PATCH] mm: __pagevec_lru_add_fn: typo fix

On 4/2/19 11:43 AM, Peng Fan wrote:
> There is no function named munlock_vma_pages, correct it to
> munlock_vma_page.
>
> Signed-off-by: Peng Fan <[email protected]>

Acked-by: Vlastimil Babka <[email protected]>

> ---
> mm/swap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/swap.c b/mm/swap.c
> index 301ed4e04320..3a75722e68a9 100644
> --- a/mm/swap.c
> +++ b/mm/swap.c
> @@ -867,7 +867,7 @@ static void __pagevec_lru_add_fn(struct page *page, struct lruvec *lruvec,
> SetPageLRU(page);
> /*
> * Page becomes evictable in two ways:
> - * 1) Within LRU lock [munlock_vma_pages() and __munlock_pagevec()].
> + * 1) Within LRU lock [munlock_vma_page() and __munlock_pagevec()].
> * 2) Before acquiring LRU lock to put the page to correct LRU and then
> * a) do PageLRU check with lock [check_move_unevictable_pages]
> * b) do PageLRU check before lock [clear_page_mlock]
>

2019-04-04 07:31:33

by Mukesh Ojha

Subject: Re: [PATCH] mm: __pagevec_lru_add_fn: typo fix

On 4/2/2019 3:13 PM, Peng Fan wrote:
> There is no function named munlock_vma_pages, correct it to
> munlock_vma_page.
>
> Signed-off-by: Peng Fan <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>

Cheers,
-Mukesh
> ---
> mm/swap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/swap.c b/mm/swap.c
> index 301ed4e04320..3a75722e68a9 100644
> --- a/mm/swap.c
> +++ b/mm/swap.c
> @@ -867,7 +867,7 @@ static void __pagevec_lru_add_fn(struct page *page, struct lruvec *lruvec,
> SetPageLRU(page);
> /*
> * Page becomes evictable in two ways:
> - * 1) Within LRU lock [munlock_vma_pages() and __munlock_pagevec()].
> + * 1) Within LRU lock [munlock_vma_page() and __munlock_pagevec()].
> * 2) Before acquiring LRU lock to put the page to correct LRU and then
> * a) do PageLRU check with lock [check_move_unevictable_pages]
> * b) do PageLRU check before lock [clear_page_mlock]