2006-03-24 16:34:14

by Alexander E. Patrakov

Subject: 2.6.16: Broken deps of spectrum_cs

In linux-2.6.16, it is possible to compile spectrum_cs.ko without enabling
firmware loader. Result:

WARNING: /lib/modules/2.6.16/kernel/drivers/net/wireless/spectrum_cs.ko
needs unknown symbol request_firmware

--
Alexander E. Patrakov

2006-03-24 16:56:31

by Adrian Bunk

Subject: [2.6 patch] PCMCIA_SPECTRUM must select FW_LOADER

On Fri, Mar 24, 2006 at 09:36:09PM +0500, Alexander E. Patrakov wrote:
> In linux-2.6.16, it is possible to compile spectrum_cs.ko without enabling
> firmware loader. Result:
>
> WARNING: /lib/modules/2.6.16/kernel/drivers/net/wireless/spectrum_cs.ko
> needs unknown symbol request_firmware

Thanks for your report, a fix is below.

> Alexander E. Patrakov

cu
Adrian


<-- snip -->


PCMCIA_SPECTRUM must select FW_LOADER.

Reported by "Alexander E. Patrakov" <[email protected]>.

Signed-off-by: Adrian Bunk <[email protected]>

--- linux-2.6.16-mm1-full/drivers/net/wireless/Kconfig.old 2006-03-24 17:45:05.000000000 +0100
+++ linux-2.6.16-mm1-full/drivers/net/wireless/Kconfig 2006-03-24 17:45:38.000000000 +0100
@@ -397,6 +397,7 @@
config PCMCIA_SPECTRUM
tristate "Symbol Spectrum24 Trilogy PCMCIA card support"
depends on NET_RADIO && PCMCIA && HERMES
+ select FW_LOADER
---help---

This is a driver for 802.11b cards using RAM-loadable Symbol

2006-03-27 22:00:05

by John W. Linville

Subject: Re: [2.6 patch] PCMCIA_SPECTRUM must select FW_LOADER

On Fri, Mar 24, 2006 at 05:56:19PM +0100, Adrian Bunk wrote:

> PCMCIA_SPECTRUM must select FW_LOADER.
>
> Reported by "Alexander E. Patrakov" <[email protected]>.
>
> Signed-off-by: Adrian Bunk <[email protected]>

Merged to the 'upstream' branch of wireless-2.6.

Thanks!

John
--
John W. Linville
[email protected]