2023-07-20 08:14:22

by Ran Sun

Subject: [PATCH] drm/i915: fix application of sizeof to pointer

The coccinelle check report:
./drivers/scsi/csiostor/csio_mb.c:1554:46-52: ERROR: application
of sizeof to pointer

Signed-off-by: Ran Sun <[email protected]>
---
drivers/gpu/drm/i915/i915_syncmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_syncmap.c
b/drivers/gpu/drm/i915/i915_syncmap.c
index 60404dbb2e9f..4eeaf12be72d 100644
--- a/drivers/gpu/drm/i915/i915_syncmap.c
+++ b/drivers/gpu/drm/i915/i915_syncmap.c
@@ -282,7 +282,7 @@ static noinline int __sync_set(struct i915_syncmap
**root, u64 id, u32 seqno)
unsigned int above;

/* Insert a join above the current layer */
- next = kzalloc(sizeof(*next) + KSYNCMAP * sizeof(next),
+ next = kzalloc(sizeof(*next) + KSYNCMAP * sizeof(*next),
GFP_KERNEL);
if (unlikely(!next))
return -ENOMEM;

2023-07-31 10:55:09

by Jani Nikula

Subject: Re: [PATCH] drm/i915: fix application of sizeof to pointer

On Thu, 20 Jul 2023, [email protected] wrote:
> The coccinelle check report:
> ./drivers/scsi/csiostor/csio_mb.c:1554:46-52: ERROR: application
> of sizeof to pointer

Please don't just assume coccinelle is right, and send "fixes" based on
the cocci reports alone. You need to read and understand the code you're
changing.


BR,
Jani.

>
> Signed-off-by: Ran Sun <[email protected]>
> ---
> drivers/gpu/drm/i915/i915_syncmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_syncmap.c
> b/drivers/gpu/drm/i915/i915_syncmap.c
> index 60404dbb2e9f..4eeaf12be72d 100644
> --- a/drivers/gpu/drm/i915/i915_syncmap.c
> +++ b/drivers/gpu/drm/i915/i915_syncmap.c
> @@ -282,7 +282,7 @@ static noinline int __sync_set(struct i915_syncmap
> **root, u64 id, u32 seqno)
> unsigned int above;
>
> /* Insert a join above the current layer */
> - next = kzalloc(sizeof(*next) + KSYNCMAP * sizeof(next),
> + next = kzalloc(sizeof(*next) + KSYNCMAP * sizeof(*next),
> GFP_KERNEL);
> if (unlikely(!next))
> return -ENOMEM;

--
Jani Nikula, Intel Open Source Graphics Center