2016-04-25 13:11:43

by Arnd Bergmann

Subject: [PATCH] drm: rcar: remove unused variable

A cleanup for the rcar-du driver left an unused variable behind:

drm/rcar-du/rcar_du_drv.c: In function 'rcar_du_probe':
drm/rcar-du/rcar_du_drv.c:300:24: error: unused variable 'connector' [-Werror=unused-variable]

This removes the variable.

Signed-off-by: Arnd Bergmann <[email protected]>
Fixes: d63c25e4245a ("drm: rcar-du: Use generic drm_connector_register_all() helper")
---
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
index 0f251dc11082..fb9242d27883 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
@@ -297,7 +297,6 @@ static int rcar_du_probe(struct platform_device *pdev)
{
struct device_node *np = pdev->dev.of_node;
struct rcar_du_device *rcdu;
- struct drm_connector *connector;
struct drm_device *ddev;
struct resource *mem;
int ret;
--
2.7.0

2016-04-25 17:04:35

by Laurent Pinchart

Subject: Re: [PATCH] drm: rcar: remove unused variable

Hi Arnd,

Thank you for the patch.

On Monday 25 Apr 2016 15:11:08 Arnd Bergmann wrote:
> A cleanup for the rcar-du driver left an unused variable behind:
>
> drm/rcar-du/rcar_du_drv.c: In function 'rcar_du_probe':
> drm/rcar-du/rcar_du_drv.c:300:24: error: unused variable 'connector'
> [-Werror=unused-variable]
>
> This removes the variable.
>
> Signed-off-by: Arnd Bergmann <[email protected]>
> Fixes: d63c25e4245a ("drm: rcar-du: Use generic drm_connector_register_all()
> helper")

I've already submitted an identical patch and Daniel Vetter has queued it up.

> ---
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 0f251dc11082..fb9242d27883
> 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -297,7 +297,6 @@ static int rcar_du_probe(struct platform_device *pdev)
> {
> struct device_node *np = pdev->dev.of_node;
> struct rcar_du_device *rcdu;
> - struct drm_connector *connector;
> struct drm_device *ddev;
> struct resource *mem;
> int ret;

--
Regards,

Laurent Pinchart