2021-08-04 12:59:15

by Alexandre Belloni

Subject: [PATCH 1/4] rtc: s5m: switch to devm_rtc_allocate_device

Switch to devm_rtc_allocate_device/devm_rtc_register_device, this allows
for further improvement of the driver.

Signed-off-by: Alexandre Belloni <[email protected]>
---
drivers/rtc/rtc-s5m.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c
index 6b56f8eacba6..4c1596c55de8 100644
--- a/drivers/rtc/rtc-s5m.c
+++ b/drivers/rtc/rtc-s5m.c
@@ -788,12 +788,16 @@ static int s5m_rtc_probe(struct platform_device *pdev)

device_init_wakeup(&pdev->dev, 1);

- info->rtc_dev = devm_rtc_device_register(&pdev->dev, "s5m-rtc",
- &s5m_rtc_ops, THIS_MODULE);
-
+ info->rtc_dev = devm_rtc_allocate_device(&pdev->dev);
if (IS_ERR(info->rtc_dev))
return PTR_ERR(info->rtc_dev);

+ info->rtc_dev->ops = &s5m_rtc_ops;
+
+ err = devm_rtc_register_device(info->rtc_dev);
+ if (err)
+ return err;
+
if (!info->irq) {
dev_info(&pdev->dev, "Alarm IRQ not available\n");
return 0;
--
2.31.1

2021-08-04 14:21:50

by Krzysztof Kozlowski

Subject: Re: [PATCH 1/4] rtc: s5m: switch to devm_rtc_allocate_device

On 04/08/2021 12:41, Alexandre Belloni wrote:
> Switch to devm_rtc_allocate_device/devm_rtc_register_device, this allows
> for further improvement of the driver.
>
> Signed-off-by: Alexandre Belloni <[email protected]>
> ---
> drivers/rtc/rtc-s5m.c | 10 +++++++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>


Reviewed-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof