On Mon, 2006-05-01 at 00:40 +0100, David Vrabel wrote:
> Thanks for doing this Pekka. I've fixed up some stuff and given it some
> brief testing on a 100BaseT network and it seems to work now.
Thanks! I merged your stuff and pushed out an updated patch.
Pekka
[PATCH] IP1000 Gigabit Ethernet device driver
This is a cleaned up fork of the IP1000A device driver:
http://www.icplus.com.tw/driver-pp-IP1000A.html
Open issues:
- ipg_probe() looks really fishy and doesn't handle all errors
(e.g. ioremap failing).
- ipg_nic_do_ioctl() is playing games with user-space pointer.
We should use ethtool ioctl instead as suggested by Arjan.
- something (PHY reset/auto negotiation?) takes 2-3 seconds and
appears to be done with interrupts disabled.
Changelog:
- Kill 2.2 and 2.4 compatability macros
- Use proper module API
- Use proper PCI API
- Use netdev_priv
- Consolidate headers to one file
- Use __iomem annotations
- Use iomap instead of read/out for I/O
- Remove obfuscating register access macros
- Remove changelogs
- Remove ether_crc_le() -- use crc32_le() instead.
- No more nonsense with root_dev -- ipg_remove() now works.
- Move PHY and MAC address initialization into the ipg_probe(). It was
previously filling in the MAC address on open which breaks some user
space.
- Folded ipg_nic_init into ipg_probe since it was broke otherwise.
I don't have the hardware, so I don't know if I broke anything.
The patch is 128 KB in size, so I am not including it in this
mail. You can find the patch here:
http://www.cs.helsinki.fi/u/penberg/linux/ip1000-driver.patch
Signed-off-by: David Vrabel <[email protected]>
Signed-off-by: Pekka Enberg <[email protected]>
On Mon, 01 May 2006 12:31:40 +0300
Pekka Enberg <[email protected]> wrote:
> [PATCH] IP1000 Gigabit Ethernet device driver
>
> This is a cleaned up fork of the IP1000A device driver:
>
> http://www.icplus.com.tw/driver-pp-IP1000A.html
Please remember that to merge this we'll need a signed-off-by from the
original developers. (That's not very gplish, but such is life).
On Wed, 3 May 2006, Andrew Morton wrote:
> Please remember that to merge this we'll need a signed-off-by from the
> original developers. (That's not very gplish, but such is life).
OK. Lets see if we can track one of them developers down. I see Craig
Rich's email (only email found in the original mail) is out of date so if
anyone knows how to reach him, please let me know. Thanks!
Pekka
Pekka J Enberg wrote:
> On Wed, 3 May 2006, Andrew Morton wrote:
>> Please remember that to merge this we'll need a signed-off-by from the
>> original developers. (That's not very gplish, but such is life).
>
> OK. Lets see if we can track one of them developers down. I see Craig
> Rich's email (only email found in the original mail) is out of date so if
> anyone knows how to reach him, please let me know. Thanks!
I think/guess that IC Plus bought out Sundance so you'd need to contact
someone at IC Plus.
David Vrabel