2006-05-15 23:57:23

by Xin Zhao

[permalink] [raw]
Subject: HELP! vfs_readv() issue

I am writing a file system, but vfs_read() sometimes return 0. What
could cause this problem?

Please help!

Xin


2006-05-16 05:30:47

by Chris Wedgwood

[permalink] [raw]
Subject: Re: HELP! vfs_readv() issue

On Mon, May 15, 2006 at 07:57:21PM -0400, Xin Zhao wrote:

> I am writing a file system, but vfs_read() sometimes return 0. What
> could cause this problem?

EOF?

2006-05-17 21:44:10

by Xin Zhao

[permalink] [raw]
Subject: Re: HELP! vfs_readv() issue

Thank you for your care. What I am trying to do is to rewrite NFS in
the virtual machine environment so that network communication can be
replaced with inter-VM communication.

But after I remove the original rpc stuff, I ran into some strange
problem, including this one. Interesting thing is that I noticed that
even with standard NFS implementation, it is still possible that
nfsd_read() return resp->count to be 0. At this time, eof is also
equal to 1. This seems to be right since NFSD already reach the end of
the file. But question is since 0 byte is read this time, NFS should
detect EOF in previous read. Why need one more read?

Xin

On 5/16/06, Chris Wedgwood <[email protected]> wrote:
> On Mon, May 15, 2006 at 07:57:21PM -0400, Xin Zhao wrote:
>
> > I am writing a file system, but vfs_read() sometimes return 0. What
> > could cause this problem?
>
> EOF?
>

2006-05-18 18:05:53

by Avishay Traeger

[permalink] [raw]
Subject: Re: HELP! vfs_readv() issue

On Wed, 2006-05-17 at 17:44 -0400, Xin Zhao wrote:
> Thank you for your care. What I am trying to do is to rewrite NFS in
> the virtual machine environment so that network communication can be
> replaced with inter-VM communication.
>
> But after I remove the original rpc stuff, I ran into some strange
> problem, including this one. Interesting thing is that I noticed that
> even with standard NFS implementation, it is still possible that
> nfsd_read() return resp->count to be 0. At this time, eof is also
> equal to 1. This seems to be right since NFSD already reach the end of
> the file. But question is since 0 byte is read this time, NFS should
> detect EOF in previous read. Why need one more read?
>
> Xin

How are you reading the file? Some programs (I believe 'cat' is one of
them) will read a file until 0 is returned. Try writing a small C
program to read a file until EOF and see if the behavior changes.

Avishay Traeger
http://www.fsl.cs.sunysb.edu/~avishay/

2006-05-18 18:12:48

by Petr Vandrovec

[permalink] [raw]
Subject: Re: HELP! vfs_readv() issue

Avishay Traeger wrote:
> On Wed, 2006-05-17 at 17:44 -0400, Xin Zhao wrote:
>
>>Thank you for your care. What I am trying to do is to rewrite NFS in
>>the virtual machine environment so that network communication can be
>>replaced with inter-VM communication.
>>
>>But after I remove the original rpc stuff, I ran into some strange
>>problem, including this one. Interesting thing is that I noticed that
>>even with standard NFS implementation, it is still possible that
>>nfsd_read() return resp->count to be 0. At this time, eof is also
>>equal to 1. This seems to be right since NFSD already reach the end of
>>the file. But question is since 0 byte is read this time, NFS should
>>detect EOF in previous read. Why need one more read?
>>
>>Xin
>
>
> How are you reading the file? Some programs (I believe 'cat' is one of
> them) will read a file until 0 is returned. Try writing a small C
> program to read a file until EOF and see if the behavior changes.

Returning 0 from read() is only situation when you can be sure you are at the
end of file. If you get short read(), it may be short due to EOF, but it may be
short also because some error was hit - EIO and EFAULT are two which can occur
almost always. And only next read will either return that error (or some other
error, or success if error condition disappeared meanwhile), or zero if it is
really EOF.
Petr