2018-01-14 21:30:08

by SF Markus Elfring

Subject: [PATCH] mfd/jz4740-adc: Delete an error message for a failed memory allocation in jz4740_adc_probe()

From: Markus Elfring <[email protected]>
Date: Sun, 14 Jan 2018 22:26:21 +0100

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <[email protected]>
---
drivers/mfd/jz4740-adc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mfd/jz4740-adc.c b/drivers/mfd/jz4740-adc.c
index 798e44306382..f4cd14294b61 100644
--- a/drivers/mfd/jz4740-adc.c
+++ b/drivers/mfd/jz4740-adc.c
@@ -212,10 +212,8 @@ static int jz4740_adc_probe(struct platform_device *pdev)
int irq_base;

adc = devm_kzalloc(&pdev->dev, sizeof(*adc), GFP_KERNEL);
- if (!adc) {
- dev_err(&pdev->dev, "Failed to allocate driver structure\n");
+ if (!adc)
return -ENOMEM;
- }

adc->irq = platform_get_irq(pdev, 0);
if (adc->irq < 0) {
--
2.15.1

2018-01-22 15:42:14

by Lee Jones

Subject: Re: [PATCH] mfd/jz4740-adc: Delete an error message for a failed memory allocation in jz4740_adc_probe()

On Sun, 14 Jan 2018, SF Markus Elfring wrote:

> From: Markus Elfring <[email protected]>
> Date: Sun, 14 Jan 2018 22:26:21 +0100
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring <[email protected]>
> ---
> drivers/mfd/jz4740-adc.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Applied, thanks.

--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog