2006-08-02 03:19:27

by Andi Kleen

Subject: Re: [PATCH 12 of 13] Pass the mm struct into the pgd_free code so the mm is available here

nst char *arch_vma_name(struct vm_area_struct *vma);
>
> +#ifndef pgd_free_mm
> +#define pgd_free_mm(mm) pgd_free((mm)->pgd)
> +#endif

Sorry, but these ifdefs are too ugly. I would prefer if you
just updated all architectures, even though it will make the patch
somewhat bigger

-Andi

2006-08-02 06:26:01

by Zachary Amsden

Subject: Re: [Xen-devel] Re: [PATCH 12 of 13] Pass the mm struct into the pgd_free code so the mm is available here

Andi Kleen wrote:
> nst char *arch_vma_name(struct vm_area_struct *vma);
>
>>
>> +#ifndef pgd_free_mm
>> +#define pgd_free_mm(mm) pgd_free((mm)->pgd)
>> +#endif
>>
>
> Sorry, but these ifdefs are too ugly. I would prefer if you
> just updated all architectures, even though it will make the patch
> somewhat bigger
>
I'm fine with doing that, and yes this is ugly. Will take awhile though
- for efficiency of mercurial patch tools, I deprecated all
architectures but i386, x86_64, and um from my local tree. <Slaps head>.

Zach

2006-08-02 07:11:47

by Chris Wright

Subject: Re: [Xen-devel] Re: [PATCH 12 of 13] Pass the mm struct into the pgd_free code so the mm is available here

* Zachary Amsden ([email protected]) wrote:
> Andi Kleen wrote:
> >nst char *arch_vma_name(struct vm_area_struct *vma);
> >
> >>
> >>+#ifndef pgd_free_mm
> >>+#define pgd_free_mm(mm) pgd_free((mm)->pgd)
> >>+#endif
> >>
> >
> >Sorry, but these ifdefs are too ugly. I would prefer if you
> >just updated all architectures, even though it will make the patch
> >somewhat bigger
> >
> I'm fine with doing that, and yes this is ugly. Will take awhile though
> - for efficiency of mercurial patch tools, I deprecated all
> architectures but i386, x86_64, and um from my local tree. <Slaps head>.

While you're at it, can you please make sure there's some nice changelog
comments. The current one only has diffstat.

thanks,
-chris