2006-08-09 08:40:42

by Jan-Bernd Themann

Subject: [PATCH 5/6] ehea: makefile

Signed-off-by: Jan-Bernd Themann <[email protected]>


drivers/net/ehea/Makefile | 7 +++++++
1 file changed, 7 insertions(+)



--- linux-2.6.18-rc4-orig/drivers/net/ehea/Makefile 1969-12-31 16:00:00.000000000 -0800
+++ kernel/drivers/net/ehea/Makefile 2006-08-08 23:59:38.083467216 -0700
@@ -0,0 +1,7 @@
+#
+# Makefile for the eHEA ethernet device driver for IBM eServer System p
+#
+
+ehea_mod-objs = ehea_main.o ehea_phyp.o ehea_qmr.o ehea_ethtool.o ehea_phyp.o
+obj-$(CONFIG_EHEA) += ehea_mod.o
+

2006-08-09 09:51:09

by Sam Ravnborg

Subject: Re: [PATCH 5/6] ehea: makefile

On Wed, Aug 09, 2006 at 10:40:20AM +0200, Jan-Bernd Themann wrote:
> Signed-off-by: Jan-Bernd Themann <[email protected]>
>
>
> drivers/net/ehea/Makefile | 7 +++++++
> 1 file changed, 7 insertions(+)
>
>
>
> --- linux-2.6.18-rc4-orig/drivers/net/ehea/Makefile 1969-12-31
> 16:00:00.000000000 -0800
> +++ kernel/drivers/net/ehea/Makefile 2006-08-08 23:59:38.083467216 -0700
> @@ -0,0 +1,7 @@
> +#
> +# Makefile for the eHEA ethernet device driver for IBM eServer System p
> +#
> +
> +ehea_mod-objs = ehea_main.o ehea_phyp.o ehea_qmr.o ehea_ethtool.o
> ehea_phyp.o
> +obj-$(CONFIG_EHEA) += ehea_mod.o
> +

Using -objs is deprecated, please use ehea_mod-y.
This needs to be documented and later warned upon which I will do soon.

Sam

2006-08-10 15:06:55

by Thomas Klein

Subject: Re: [PATCH 5/6] ehea: makefile

Sam Ravnborg wrote:
> On Wed, Aug 09, 2006 at 10:40:20AM +0200, Jan-Bernd Themann wrote:
>
>> Signed-off-by: Jan-Bernd Themann <[email protected]>
>>
>>
>> drivers/net/ehea/Makefile | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>>
>>
>> --- linux-2.6.18-rc4-orig/drivers/net/ehea/Makefile 1969-12-31
>> 16:00:00.000000000 -0800
>> +++ kernel/drivers/net/ehea/Makefile 2006-08-08 23:59:38.083467216 -0700
>> @@ -0,0 +1,7 @@
>> +#
>> +# Makefile for the eHEA ethernet device driver for IBM eServer System p
>> +#
>> +
>> +ehea_mod-objs = ehea_main.o ehea_phyp.o ehea_qmr.o ehea_ethtool.o
>> ehea_phyp.o
>> +obj-$(CONFIG_EHEA) += ehea_mod.o
>> +
>>
>
> Using -objs is deprecated, please use ehea_mod-y.
> This needs to be documented and later warned upon which I will do soon.
>
> Sam
>
Done. Will be included in next patch.