2006-08-14 19:28:13

by Kevin Hilman

Subject: [PATCH] net/atm compile error on ARM

atm_proc_exit() is declared as __exit, and thus in .exit.text. On
some architectures (ARM) .exit.text is discarded at compile time, and
since atm_proc_exit() is called by some other __init functions, it
results in a link error.

Signed-off-by: Kevin Hilman <[email protected]>

Index: ixp4xx/net/atm/proc.c
===================================================================
--- ixp4xx.orig/net/atm/proc.c
+++ ixp4xx/net/atm/proc.c
@@ -507,7 +507,7 @@ err_out:
goto out;
}

-void __exit atm_proc_exit(void)
+void atm_proc_exit(void)
{
atm_proc_dirs_remove();
}

2006-08-15 09:03:09

by David Miller

Subject: Re: [PATCH] net/atm compile error on ARM

From: Kevin Hilman <[email protected]>
Date: Mon, 14 Aug 2006 12:28:09 -0700

> atm_proc_exit() is declared as __exit, and thus in .exit.text. On
> some architectures (ARM) .exit.text is discarded at compile time, and
> since atm_proc_exit() is called by some other __init functions, it
> results in a link error.
>
> Signed-off-by: Kevin Hilman <[email protected]>

Patch applied, thanks Kevin.