On Thu, Aug 17, 2006 at 04:26:35AM +0000, Michal Piotrowski wrote:
>
> Hi,
>
> pci_module_init is obsolete.
>
> This patch series converts pci_module_init to pci_register_driver.
>
>
> Can I remove this?
>
> include/linux/pci.h:385
> /*
> * pci_module_init is obsolete, this stays here till we fix up all usages of it
> * in the tree.
> */
> #define pci_module_init pci_register_driver
As repeated numerous times, it's up to the network developers if they
will take this or not.
I'll hold off on taking this series, please push it through the driver
subsystem maintainers.
thanks,
greg k-h
Greg KH wrote:
> On Thu, Aug 17, 2006 at 04:26:35AM +0000, Michal Piotrowski wrote:
>> Hi,
>>
>> pci_module_init is obsolete.
>>
>> This patch series converts pci_module_init to pci_register_driver.
>>
>>
>> Can I remove this?
>>
>> include/linux/pci.h:385
>> /*
>> * pci_module_init is obsolete, this stays here till we fix up all usages of it
>> * in the tree.
>> */
>> #define pci_module_init pci_register_driver
>
> As repeated numerous times, it's up to the network developers if they
> will take this or not.
>
> I'll hold off on taking this series, please push it through the driver
> subsystem maintainers.
It's already in subsystem trees, in fact.
But it is most definitely not 2.6.18-rc material :)
Jeff
> But it is most definitely not 2.6.18-rc material :)
that part of it isn't.. marking it deprecated so that people doing new
code get a warning probably IS 2.6.18, the sooner that happens the
better....
--
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
Arjan van de Ven wrote:
>> But it is most definitely not 2.6.18-rc material :)
>
> that part of it isn't.. marking it deprecated so that people doing new
> code get a warning probably IS 2.6.18, the sooner that happens the
> better....
I disagree. With all the cleanups going into 2.6.19, that would just
introduce needless build noise into 2.6.18.
Jeff
On 17/08/06, Jeff Garzik <[email protected]> wrote:
> Greg KH wrote:
> > On Thu, Aug 17, 2006 at 04:26:35AM +0000, Michal Piotrowski wrote:
> >> Hi,
> >>
> >> pci_module_init is obsolete.
> >>
> >> This patch series converts pci_module_init to pci_register_driver.
> >>
> >>
> >> Can I remove this?
> >>
> >> include/linux/pci.h:385
> >> /*
> >> * pci_module_init is obsolete, this stays here till we fix up all usages of it
> >> * in the tree.
> >> */
> >> #define pci_module_init pci_register_driver
> >
> > As repeated numerous times, it's up to the network developers if they
> > will take this or not.
> >
> > I'll hold off on taking this series, please push it through the driver
> > subsystem maintainers.
>
> It's already in subsystem trees, in fact.
Did you mean http://www.kernel.org/git/?p=linux/kernel/git/davem/net-2.6.19.git;a=shortlog
?
The patches are against 2.6.18-rc4-mm1. Unfortunately patches weren't
delivered to netdev (my fault). I'll add To:<actual maintainer> and
resend.
>
> But it is most definitely not 2.6.18-rc material :)
I agree.
>
> Jeff
>
Regards,
Michal
--
Michal K. K. Piotrowski
LTG - Linux Testers Group
(http://www.stardust.webpages.pl/ltg/wiki/)
Actually, I stand corrected: netdev-2.6.git#upstream does not contain a
pci_register_driver() patch.
Send the drivers/net piece along to me and I'll apply it.
Jeff
On Thu, Aug 17, 2006 at 08:35:12AM -0400, Jeff Garzik wrote:
> Greg KH wrote:
> >On Thu, Aug 17, 2006 at 04:26:35AM +0000, Michal Piotrowski wrote:
> >>Hi,
> >>
> >>pci_module_init is obsolete.
> >>
> >>This patch series converts pci_module_init to pci_register_driver.
> >>
> >>
> >>Can I remove this?
> >>
> >>include/linux/pci.h:385
> >>/*
> >> * pci_module_init is obsolete, this stays here till we fix up all usages
> >> of it
> >> * in the tree.
> >> */
> >>#define pci_module_init pci_register_driver
> >
> >As repeated numerous times, it's up to the network developers if they
> >will take this or not.
> >
> >I'll hold off on taking this series, please push it through the driver
> >subsystem maintainers.
>
> It's already in subsystem trees, in fact.
Great, it can wait until 2.6.19.
> But it is most definitely not 2.6.18-rc material :)
Agreed.
thanks,
greg k-h